Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2439063002: [heap] Refactor marking deque. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Refactor marking deque. This patch moves management of marking deque backing store into the MarkingDeque class, which will simplify unmapping of backing store in concurrent task. BUG= Committed: https://crrev.com/ad815a7b9a2c56ff10e1ffbbe780d74992459da1 Cr-Commit-Position: refs/heads/master@{#40523}

Patch Set 1 #

Patch Set 2 : undo redundant changes #

Total comments: 1

Patch Set 3 : Stop incremental marking if it is in sweeping state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -113 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/mark-compact.h View 1 5 chunks +17 lines, -22 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 8 chunks +58 lines, -77 lines 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
ulan
ptal
4 years, 2 months ago (2016-10-21 12:49:09 UTC) #2
ulan
https://codereview.chromium.org/2439063002/diff/20001/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/2439063002/diff/20001/src/heap/mark-compact.h#newcode137 src/heap/mark-compact.h:137: int top_; I will change int -> size_t in ...
4 years, 2 months ago (2016-10-21 12:52:49 UTC) #3
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-21 13:38:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439063002/40001
4 years, 1 month ago (2016-10-24 08:25:58 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-24 09:07:02 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ad815a7b9a2c56ff10e1ffbbe780d74992459da1
Cr-Commit-Position: refs/heads/master@{#40523}

Powered by Google App Engine
This is Rietveld 408576698