Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 244243002: Pass SharedBuffer by reference to DeferredImageDecoder::setData() (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Pass SharedBuffer by reference to DeferredImageDecoder::setData() Pass SharedBuffer by reference to DeferredImageDecoder::setData() as it can never be null. This gets rid of a few unnecessary null checks. The existing code would have crashed anyway if the pointer were null as 1 null check was missing. R=abarth@chromium.org, eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172000

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/graphics/DeferredImageDecoder.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +7 lines, -7 lines 1 comment Download
M Source/platform/graphics/DeferredImageDecoderTest.cpp View 11 chunks +13 lines, -13 lines 0 comments Download
M Source/platform/graphics/ImageSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageSource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
https://codereview.chromium.org/244243002/diff/1/Source/platform/graphics/DeferredImageDecoder.cpp File Source/platform/graphics/DeferredImageDecoder.cpp (left): https://codereview.chromium.org/244243002/diff/1/Source/platform/graphics/DeferredImageDecoder.cpp#oldcode127 Source/platform/graphics/DeferredImageDecoder.cpp:127: m_lastDataSize = data->size(); There was no null check here.
6 years, 8 months ago (2014-04-20 13:16:50 UTC) #1
abarth-chromium
lgtm :)
6 years, 8 months ago (2014-04-20 14:17:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/244243002/1
6 years, 8 months ago (2014-04-20 14:17:58 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-20 14:37:40 UTC) #4
Message was sent while issue was closed.
Change committed as 172000

Powered by Google App Engine
This is Rietveld 408576698