Source/modules/imagebitmap/ImageBitmapFactories.cpp - Issue 244243002: Pass SharedBuffer by reference to DeferredImageDecoder::setData()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/imagebitmap/ImageBitmapFactories.cpp

Issue 244243002: Pass SharedBuffer by reference to DeferredImageDecoder::setData() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/imagebitmap/ImageBitmapFactories.cpp

diff --git a/Source/modules/imagebitmap/ImageBitmapFactories.cpp b/Source/modules/imagebitmap/ImageBitmapFactories.cpp

index 3e6429ffaed1745d1a38c630e9490dc2729c6e53..42411e66fe4670e475081e125f59145c066205dd 100644

--- a/Source/modules/imagebitmap/ImageBitmapFactories.cpp

+++ b/Source/modules/imagebitmap/ImageBitmapFactories.cpp

@@ -301,7 +301,7 @@ void ImageBitmapFactories::ImageBitmapLoader::didFinishLoading()

RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create((char*)m_loader.arrayBufferResult()->data(), m_loader.arrayBufferResult()->byteLength());

OwnPtr<ImageSource> source = adoptPtr(new ImageSource());

- source->setData(sharedBuffer.get(), true);

+ source->setData(*sharedBuffer, true);

RefPtr<NativeImageSkia> imageSkia = source->createFrameAtIndex(0);

if (!imageSkia) {

rejectPromise();