git_cl: fix GetPreferredTryMasters() feature

git_cl: fix GetPreferredTryMasters() feature

It was broken in https://chromiumcodereview.appspot.com/2419113002

R=borenet@chromium.org
BUG=658317
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/70d11c3759a5113bd2c26a1026467021caac6327

[nodir, 2016-10-24 18:26:03]

https://codereview.chromium.org/2442393002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2442393002/diff/1/git_cl.py#newcode4798
git_cl.py:4798: return masters
conversion to buckets did not happen in this exit point

[nodir, 2016-10-24 18:27:28]

scheduled builds on https://codereview.chromium.org/2446703002 by running just
`git cl try`

[borenet2, 2016-10-24 18:31:03]

LGTM but you'll probably need a depot_tools OWNER.

https://codereview.chromium.org/2442393002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2442393002/diff/1/git_cl.py#newcode4798
git_cl.py:4798: return masters
On 2016/10/24 18:26:03, nodir wrote:
> conversion to buckets did not happen in this exit point

Thanks, I missed this early return in my CL.

[agable, 2016-10-24 18:44:01]

agable@chromium.org changed reviewers:
+ agable@chromium.org

[agable, 2016-10-24 18:44:01]

lgtm

[nodir, 2016-10-24 18:44:42]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-10-24 18:44:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 18:48:02]

Description was changed from

==========
git_cl: fix GetPreferredTryMasters() feature

It was broken in https://chromiumcodereview.appspot.com/2419113002

R=borenet@chromium.org
BUG=658317
==========

to

==========
git_cl: fix GetPreferredTryMasters() feature

It was broken in https://chromiumcodereview.appspot.com/2419113002

R=borenet@chromium.org
BUG=658317

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/70d11c3759a511...
==========

[commit-bot: I haz the power, 2016-10-24 18:48:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/70d11c3759a511...