Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: git_cl.py

Issue 2442393002: git_cl: fix GetPreferredTryMasters() feature (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index a1cc0fa42f702f8c2c8061bc24f11b335a13abaf..c130f3d770a003dc0bfc3404805a428b86bb2a4c 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -4780,6 +4780,7 @@ def CMDtry(parser, args):
', e.g. "-m tryserver.chromium.linux".' % err_msg)
def GetMasterMap():
+ """Returns {master: {builder_name: [test_names]}}. Not buckets!"""
# Process --bot.
if not options.bot:
change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
@@ -4829,16 +4830,17 @@ def CMDtry(parser, args):
# Return a master map with one master to be backwards compatible. The
# master name defaults to an empty string, which will cause the master
# not to be set on rietveld (deprecated).
- bucket = ''
- if options.master:
- # Add the "master." prefix to the master name to obtain the bucket name.
- bucket = _prefix_master(options.master)
- return {bucket: builders_and_tests}
+ return {options.master: builders_and_tests}
if options.bucket:
buckets = {options.bucket: {b: [] for b in options.bot}}
else:
- buckets = GetMasterMap()
+ buckets = {}
+ for master, data in GetMasterMap().iteritems():
+ # Add the "master." prefix to the master name to obtain the bucket name.
+ bucket = _prefix_master(master) if master else ''
+ buckets[bucket] = data
+
if not buckets:
# Default to triggering Dry Run (see http://crbug.com/625697).
if options.verbose:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698