Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2442333002: [regexp] Mark functions MUST_USE_RESULT (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Mark functions MUST_USE_RESULT BUG=v8:5339 Committed: https://crrev.com/8f770ad9ecd13a20ff17ef81dcf05d3a8337338f Cr-Commit-Position: refs/heads/master@{#40545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M src/builtins/builtins-regexp.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M src/regexp/regexp-utils.h View 2 chunks +10 lines, -12 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 1 month ago (2016-10-24 13:34:36 UTC) #4
Yang
On 2016/10/24 13:34:36, jgruber wrote: lgtm.
4 years, 1 month ago (2016-10-25 07:06:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442333002/1
4 years, 1 month ago (2016-10-25 07:07:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 07:08:59 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f770ad9ecd13a20ff17ef81dcf05d3a8337338f
Cr-Commit-Position: refs/heads/master@{#40545}

Powered by Google App Engine
This is Rietveld 408576698