Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: src/regexp/regexp-utils.h

Issue 2442333002: [regexp] Mark functions MUST_USE_RESULT (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-regexp.cc ('k') | src/runtime/runtime-regexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/regexp/regexp-utils.h
diff --git a/src/regexp/regexp-utils.h b/src/regexp/regexp-utils.h
index 8a5a099182183d2b72187910af846fe5dd8dc978..eff1ed739c459c8ce473b4227807ff3001f7d39b 100644
--- a/src/regexp/regexp-utils.h
+++ b/src/regexp/regexp-utils.h
@@ -19,16 +19,15 @@ class RegExpUtils : public AllStatic {
int capture, bool* ok = nullptr);
// Last index (RegExp.lastIndex) accessors.
- static MaybeHandle<Object> SetLastIndex(Isolate* isolate,
- Handle<JSReceiver> regexp, int value);
- static MaybeHandle<Object> GetLastIndex(Isolate* isolate,
- Handle<JSReceiver> recv);
+ static MUST_USE_RESULT MaybeHandle<Object> SetLastIndex(
+ Isolate* isolate, Handle<JSReceiver> regexp, int value);
+ static MUST_USE_RESULT MaybeHandle<Object> GetLastIndex(
+ Isolate* isolate, Handle<JSReceiver> recv);
// ES#sec-regexpexec Runtime Semantics: RegExpExec ( R, S )
- static MaybeHandle<Object> RegExpExec(Isolate* isolate,
- Handle<JSReceiver> regexp,
- Handle<String> string,
- Handle<Object> exec);
+ static MUST_USE_RESULT MaybeHandle<Object> RegExpExec(
+ Isolate* isolate, Handle<JSReceiver> regexp, Handle<String> string,
+ Handle<Object> exec);
// ES#sec-isregexp IsRegExp ( argument )
// Includes checking of the match property.
@@ -42,10 +41,9 @@ class RegExpUtils : public AllStatic {
// AdvanceStringIndex ( S, index, unicode )
static int AdvanceStringIndex(Isolate* isolate, Handle<String> string,
int index, bool unicode);
- static MaybeHandle<Object> SetAdvancedStringIndex(Isolate* isolate,
- Handle<JSReceiver> regexp,
- Handle<String> string,
- bool unicode);
+ static MUST_USE_RESULT MaybeHandle<Object> SetAdvancedStringIndex(
+ Isolate* isolate, Handle<JSReceiver> regexp, Handle<String> string,
+ bool unicode);
};
} // namespace internal
« no previous file with comments | « src/builtins/builtins-regexp.cc ('k') | src/runtime/runtime-regexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698