Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2442323002: Update NotificationImageLoaderTest with better timeout values. (Closed)

Created:
4 years, 1 month ago by harkness
Modified:
4 years, 1 month ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews, haraken, Peter Beverloo, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update NotificationImageLoaderTest with better timeout values. Because of crbug.com/657517 the original submit of the test for NotificationImageLoader had a very loose timeout value. Now that the bug was fixed (https://chromiumcodereview.appspot.com/2433323003), this CL updates the timeout values to be tighter. BUG=579137 Committed: https://crrev.com/deebbc09af6e8911d47f057b1e1b64500a7037ed Cr-Commit-Position: refs/heads/master@{#427074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
harkness
4 years, 1 month ago (2016-10-24 12:52:37 UTC) #2
Peter Beverloo
lgtm Please refer to the CL that fixed this in the description: https://chromiumcodereview.appspot.com/2433323003
4 years, 1 month ago (2016-10-24 13:08:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442323002/1
4 years, 1 month ago (2016-10-24 14:00:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 15:10:52 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 15:16:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/deebbc09af6e8911d47f057b1e1b64500a7037ed
Cr-Commit-Position: refs/heads/master@{#427074}

Powered by Google App Engine
This is Rietveld 408576698