Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

Issue 2442323002: Update NotificationImageLoaderTest with better timeout values. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp
diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp b/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp
index a66643e8bc673ddd6c7943d6eb8254cc98936560..bcb59f4d19f6523ba1a2570ff293250865609682 100644
--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp
+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp
@@ -96,10 +96,7 @@ TEST_F(NotificationImageLoaderTest, TimeoutTest) {
EXPECT_EQ(LoadState::kNotLoaded, loaded());
// Now advance time until a timeout should be expected.
- // Note: Because of crbug.com/657517, the platform's time doesn't
- // actually update unless a task runs, so the platform still thinks it's the
- // start time. To trigger a timeout, we have to advance the full time again.
- testingPlatform.runForPeriodSeconds(kImageFetchTimeoutInMs / 1000 + 1);
+ testingPlatform.runForPeriodSeconds(2);
// If the loader times out, it calls the callback and returns an empty bitmap.
EXPECT_EQ(LoadState::kLoadFailed, loaded());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698