Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py

Issue 2442273003: Fix for rebaseline-cl --only-changed-tests: use hard-coded constant layout test dir. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
index 57bf79ba83902f8c1322ce1b471af9451c1aa031..5393a0e3a817205d11bc4bba37a11dc01fd624a4 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
@@ -88,6 +88,12 @@ class WebKitFinder(object):
def layout_test_name(self, file_path):
"""Returns a layout test name, given the path from the repo root.
+ Note: this appears to not work on Windows; see crbug.com/658795.
+ Also, this function duplicates functionality that's in
+ Port.relative_test_filename.
+ TODO(qyearsley): De-duplicate this and Port.relative_test_filename,
+ and ensure that it works properly with Windows paths.
+
Args:
file_path: A relative path from the root of the Chromium repo.
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698