Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2442273003: Fix for rebaseline-cl --only-changed-tests: use hard-coded constant layout test dir. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
index 03267c4e376e540782b4d1f51e53c097fa9884ac..9bd8e5bbfd340eb988d3d1234432c614e357af81 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
@@ -158,8 +158,11 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
builds_to_tests = self._builds_to_tests(issue_number)
if only_changed_tests:
files_in_cl = self.rietveld.changed_files(issue_number)
- finder = WebKitFinder(self._tool.filesystem)
- tests_in_cl = [finder.layout_test_name(f) for f in files_in_cl]
+ # Note, in the changed files list from Rietveld, paths always
+ # use / as the separator, and they're always relative to repo root.
+ # TODO(qyearsley): Do this without using a hard-coded constant.
+ test_base = 'third_party/WebKit/LayoutTests/'
+ tests_in_cl = [f[len(test_base):] for f in files_in_cl if f.startswith(test_base)]
result = {}
for build, tests in builds_to_tests.iteritems():
for test in tests:
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698