Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2442273003: Fix for rebaseline-cl --only-changed-tests: use hard-coded constant layout test dir. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke, zakerinasab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for rebaseline-cl --only-changed-tests: use hard-coded constant layout test dir. This is meant to be a quick fix so that rebaseline-cl can get the list of changed tests correctly regardless of what the user's OS is (http://crbug.com/658795). This CL adds a couple of TODO notes where I think I should make follow-up CLs. BUG=658795 Committed: https://crrev.com/2774ec5c145d28382c52bf3a625c3bd212d1b83c Cr-Commit-Position: refs/heads/master@{#427530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
qyearsley
4 years, 1 month ago (2016-10-24 18:46:21 UTC) #3
qyearsley
4 years, 1 month ago (2016-10-25 20:16:08 UTC) #6
wkorman
lgtm
4 years, 1 month ago (2016-10-25 23:14:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442273003/1
4 years, 1 month ago (2016-10-25 23:18:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 23:24:25 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2774ec5c145d28382c52bf3a625c3bd212d1b83c Cr-Commit-Position: refs/heads/master@{#427530}
4 years, 1 month ago (2016-10-25 23:26:52 UTC) #15
Dirk Pranke
4 years, 1 month ago (2016-10-26 18:03:02 UTC) #16
Message was sent while issue was closed.
Seems like it would've been almost as easy to fix it properly, but lgtm as a
workaround ...

Powered by Google App Engine
This is Rietveld 408576698