Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2442243002: [turbofan] Also constant-fold String element access if possible. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also constant-fold String element access if possible. When accessing elements of a compile-time constant String, we don't need to check the receiver, and we can constant-fold the loading of the length. R=yangguo@chromium.org Committed: https://crrev.com/8e7426173b63a3090b880b7353911d8ba8501a12 Cr-Commit-Position: refs/heads/master@{#40521}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +31 lines, -2 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-10-24 06:42:44 UTC) #1
Yang
lgtm https://codereview.chromium.org/2442243002/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/2442243002/diff/1/src/compiler/js-native-context-specialization.cc#newcode687 src/compiler/js-native-context-specialization.cc:687: if (nexus.GetKeyType() == ELEMENT) { So... if the ...
4 years, 1 month ago (2016-10-24 06:48:32 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/2442243002/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/2442243002/diff/1/src/compiler/js-native-context-specialization.cc#newcode687 src/compiler/js-native-context-specialization.cc:687: if (nexus.GetKeyType() == ELEMENT) { Follow-up CL.
4 years, 1 month ago (2016-10-24 07:34:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442243002/1
4 years, 1 month ago (2016-10-24 07:34:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 07:38:45 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e7426173b63a3090b880b7353911d8ba8501a12
Cr-Commit-Position: refs/heads/master@{#40521}

Powered by Google App Engine
This is Rietveld 408576698