Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2442233002: [turbofan] Constant-fold "length" property on strings. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Constant-fold "length" property on strings. When lowering loads of "length" on compile-time constant strings, generate constant length instead of a load. R=yangguo@chromium.org Committed: https://crrev.com/a2d4a7932e58f25938aa8e269d3d4c56500f71aa Cr-Commit-Position: refs/heads/master@{#40518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/compiler/js-native-context-specialization.cc View 2 chunks +8 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 1 month ago (2016-10-24 05:57:24 UTC) #1
Yang
On 2016/10/24 05:57:24, Benedikt Meurer wrote: lgtm.
4 years, 1 month ago (2016-10-24 05:58:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442233002/1
4 years, 1 month ago (2016-10-24 06:00:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 06:25:14 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2d4a7932e58f25938aa8e269d3d4c56500f71aa
Cr-Commit-Position: refs/heads/master@{#40518}

Powered by Google App Engine
This is Rietveld 408576698