Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: recipe_modules/properties/example.py

Issue 2442173003: Add cleaned up Gerrit props to properties.test_api.tryserver. (Closed)
Patch Set: +nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/properties/example.py
diff --git a/recipe_modules/properties/example.py b/recipe_modules/properties/example.py
index 59456060dc398caaaef27cff8b576db8a53e30b0..0fb521a47b5ba7075bcc5d010b122247db82e78c 100644
--- a/recipe_modules/properties/example.py
+++ b/recipe_modules/properties/example.py
@@ -43,16 +43,36 @@ def GenTests(api):
)
# Some default buildbot configurations.
- yield api.test('buildbot_generic') + api.properties.generic(
- test_prop=None, **pd)
+ pd['test_prop'] = None
+ yield api.test('buildbot_generic') + api.properties.generic(**pd)
yield (api.test('buildbot_scheduled') +
- api.properties.scheduled(test_prop=None, **pd))
+ api.properties.scheduled(**pd))
yield (api.test('buildbot_git_scheduled') +
- api.properties.git_scheduled(test_prop=None, **pd))
+ api.properties.git_scheduled(**pd))
yield (api.test('buildbot_tryserver') +
- api.properties.tryserver(test_prop=None, **pd))
+ api.properties.tryserver(**pd))
yield (api.test('buildbot_tryserver_gerrit') +
+ api.properties.tryserver(gerrit_project='infra/infra', **pd))
+ yield (api.test('buildbot_tryserver_gerrit_override_gerrit') +
+ api.properties.tryserver(
+ gerrit_project='infra/internal',
+ gerrit_url='https://chrome-internal-review.googlesource.com',
+ **pd))
+ yield (api.test('buildbot_tryserver_gerrit_override_git') +
+ api.properties.tryserver(
+ gerrit_project='infra/hidden',
+ git_url='https://chrome-internal.googlesource.com/infra/hidden',
+ **pd))
+ yield (api.test('buildbot_tryserver_gerrit_override_both') +
+ api.properties.tryserver(
+ gerrit_project='custom',
+ gerrit_url='https://gerrit.my.host',
+ git_url='https://git.my.host/custom',
+ patch_issue=4455,
+ **pd))
+ # TODO(tandrii): remove this one. Use the above version instead.
+ yield (api.test('buildbot_tryserver_gerrit_deprecated') +
api.properties.tryserver_gerrit(
full_project_name='infra/infra',
- gerrit_host='pdfium-review.googlesource.com', test_prop=None,
+ gerrit_host='pdfium-review.googlesource.com',
**pd))
« no previous file with comments | « no previous file | recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698