recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json - Issue 2442173003: Add cleaned up Gerrit props to properties.test_api.tryserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json

Issue 2442173003: Add cleaned up Gerrit props to properties.test_api.tryserver. (Closed)

Patch Set: +nit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « recipe_modules/properties/example.py ('k') | recipe_modules/properties/example.expected/buildbot_tryserver_gerrit_deprecated.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json

diff --git a/recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json b/recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json

index 1ba21a7214ea7a766118378e2c824c95544f83f3..22666d20ec27bb40f73c5f226ce4e5a5d726c657 100644

--- a/recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json

+++ b/recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json

@@ -11,26 +11,20 @@

"cmd": [

"echo",

"('blamelist', ['cool_dev1337@chromium.org', 'hax@chromium.org'])",

- "('branch', '')",

"('buildbotURL', 'http://c.org/p/cr/')",

"('buildername', 'TestBuilder')",

"('buildnumber', 571)",

- "('category', 'cq')",

- "('event.change.id', u'infra%2Finfra~master~Ideadbeaf')",

- "('event.change.number', 338811)",

- "('event.change.url', u'https://pdfium-review.googlesource.com/#/c/338811')",

- "('event.patchSet.ref', u'refs/changes/11/338811/3')",

"('foo.bar-bam', 'thing')",

- "('gerrit', 'https://pdfium-review.googlesource.com')",

"('mastername', 'chromium.testing.master')",

+ "('patch_branch', 'master')",

+ "('patch_gerrit_url', 'https://chromium-review.googlesource.com')",

+ "('patch_issue', 456789)",

"('patch_project', 'infra/infra')",

+ "('patch_ref', 'refs/changes/89/456789/12')",

+ "('patch_repository_url', 'https://chromium.googlesource.com/infra/infra')",

+ "('patch_set', 12)",

"('patch_storage', 'gerrit')",

- "('project', 'infra/infra')",

- "('reason', 'CQ')",

"('recipe', 'properties:example')",

- "('repository', 'https://pdfium.googlesource.com/infra/infra')",

- "('requester', 'commit-bot@chromium.org')",

- "('revision', 'HEAD')",

"('slavename', 'TestSlavename')",

"('test_prop', None)",

"('workdir', '/path/to/workdir/TestSlavename')"