Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 2441993002: [regexp] Move RegExp.prototype.test to TF (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Move RegExp.prototype.test to TF This results in a speedup of around 2x. RegExpExec is also ported in this CL. BUG=v8:5339 Committed: https://crrev.com/ae3357d216ed3ce82deed2ad2c6bb526370ef6aa Cr-Commit-Position: refs/heads/master@{#40532}

Patch Set 1 #

Patch Set 2 : [regexp] More RegExp.prototype.test to TF #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : Add 'exec' to heap constants #

Patch Set 5 : Remove unused variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -24 lines) Patch
M src/bootstrapper.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/builtins/builtins.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-regexp.cc View 1 2 3 4 2 chunks +95 lines, -14 lines 0 comments Download
M src/heap-symbols.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/regexp-utils.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (20 generated)
jgruber
4 years, 2 months ago (2016-10-21 10:52:14 UTC) #5
Yang
lgtm https://codereview.chromium.org/2441993002/diff/40001/src/builtins/builtins-regexp.cc File src/builtins/builtins-regexp.cc (right): https://codereview.chromium.org/2441993002/diff/40001/src/builtins/builtins-regexp.cc#newcode1006 src/builtins/builtins-regexp.cc:1006: isolate->factory()->NewStringFromAsciiChecked("exec", TENURED)); Maybe put this in heap-symbols.h?
4 years, 1 month ago (2016-10-24 08:07:06 UTC) #12
jgruber
https://codereview.chromium.org/2441993002/diff/40001/src/builtins/builtins-regexp.cc File src/builtins/builtins-regexp.cc (right): https://codereview.chromium.org/2441993002/diff/40001/src/builtins/builtins-regexp.cc#newcode1006 src/builtins/builtins-regexp.cc:1006: isolate->factory()->NewStringFromAsciiChecked("exec", TENURED)); On 2016/10/24 08:07:06, Yang wrote: > Maybe ...
4 years, 1 month ago (2016-10-24 09:28:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441993002/80001
4 years, 1 month ago (2016-10-24 12:36:32 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-24 12:40:53 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:06 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ae3357d216ed3ce82deed2ad2c6bb526370ef6aa
Cr-Commit-Position: refs/heads/master@{#40532}

Powered by Google App Engine
This is Rietveld 408576698