Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2440893003: [regexp] Extract implementation of RE.prototype.exec (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Extract implementation of RE.prototype.exec This will have additional use sites in TurboFan soon once RegExpExec is ported. BUG=v8:5339 Committed: https://crrev.com/fa907e1559b1c3d97a34e44f53d7ddffee76459c Cr-Commit-Position: refs/heads/master@{#40529}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M src/builtins/builtins-regexp.cc View 1 2 4 chunks +35 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
jgruber
4 years, 2 months ago (2016-10-21 10:46:26 UTC) #6
Yang
On 2016/10/21 10:46:26, jgruber wrote: lgtm.
4 years, 1 month ago (2016-10-24 09:20:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440893003/40001
4 years, 1 month ago (2016-10-24 09:26:49 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-24 11:01:18 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:55 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fa907e1559b1c3d97a34e44f53d7ddffee76459c
Cr-Commit-Position: refs/heads/master@{#40529}

Powered by Google App Engine
This is Rietveld 408576698