Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)
Patch Set: test fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
index f50328a3d41a3c35f1fce879eefbddceb0e14c78..54b07fbe309c849568b79efc944563609682cb0f 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
@@ -165,7 +165,7 @@ WebInspector.Linkifier.prototype = {
maybeLinkifyScriptLocation: function(target, scriptId, sourceURL, lineNumber, columnNumber, classes)
{
var fallbackAnchor = sourceURL ? WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, columnNumber, classes) : null;
- if (!target || target.isDetached())
+ if (!target || target.isDisposed())
return fallbackAnchor;
var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
if (!debuggerModel)
@@ -235,7 +235,7 @@ WebInspector.Linkifier.prototype = {
var topFrame = stackTrace.callFrames[0];
var fallbackAnchor = WebInspector.linkifyResourceAsNode(topFrame.url, topFrame.lineNumber, topFrame.columnNumber, classes);
- if (target.isDetached())
+ if (target.isDisposed())
return fallbackAnchor;
var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);

Powered by Google App Engine
This is Rietveld 408576698