Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)
Patch Set: test fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js b/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
index 29e0293e20a5ede5d560b2dd617446c8fe806662..3f7f7c0738c6c04aa91b3a40bec74b0c3481cd4b 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
@@ -34,12 +34,15 @@ Audits2Service.prototype = {
},
/**
- * @param {!Object=} params
+ * @param {{message: !Object|string}} params
pfeldman 2016/10/21 21:04:34 design: we should not use either or typing.
* @return {!Promise}
*/
dispatchProtocolMessage: function(params)
{
- console.error("message: " + JSON.stringify(params));
+ var message = params.message;
+ if (typeof message !== "string")
+ message = JSON.stringify(message);
+ console.error("message: " + message.substring(0, 100));
return Promise.resolve();
},

Powered by Google App Engine
This is Rietveld 408576698