third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js - Issue 2441933002: [DevTools] Refactor connection-related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)

Patch Set: test fixes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js ('K') | « third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js ('k') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('j') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

index 668ed727db650943f4740bdce7d186cf3d1c05fd..b60da436663b5ec460be5750232ef9453e9a5cf9 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

@@ -798,7 +798,7 @@ WebInspector.BreakpointManager.TargetBreakpoint.prototype = {

_updateInDebugger: function(callback)

{

- if (this.target().isDetached()) {

+ if (this.target().isDisposed()) {

this._cleanUpAfterDebuggerIsGone();

callback();

return;