Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2441923004: Revert of Added common layout framework for system menu rows. (Closed)

Created:
4 years, 2 months ago by Peter Kasting
Modified:
4 years, 2 months ago
Reviewers:
tdanderson, sky, bruthig
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added common layout framework for system menu rows. (patchset #7 id:120001 of https://chromiumcodereview.appspot.com/2414103003/ ) Reason for revert: Many ash_unittests failures on Linux, see e.g. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/17106 Original issue's description: > Added common layout framework for system menu rows. > > Currently most of the system menu rows define their own layouts even > though many rows should have the same layout. Additionally we have to > support two separate layout schemes while material design is being > implemented. Thus this CL lays the ground work to make it easier to > support multiple layout schemes and a centralized layout source. > > Follow-up TODO: > - wire in the new layouts to the system menu rows > > BUG=657669 TBR=tdanderson@chromium.org,sky@chromium.org,bruthig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657669 Committed: https://crrev.com/eb262a45b811e708af8a5ec2ee0ccada3ccb2758 Cr-Commit-Position: refs/heads/master@{#426692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1353 lines) Patch
M ash/BUILD.gn View 4 chunks +0 lines, -8 lines 0 comments Download
D ash/common/system/tray/size_range_layout.h View 1 chunk +0 lines, -112 lines 0 comments Download
D ash/common/system/tray/size_range_layout.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D ash/common/system/tray/size_range_layout_unittest.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D ash/common/system/tray/three_view_layout.h View 1 chunk +0 lines, -158 lines 0 comments Download
D ash/common/system/tray/three_view_layout.cc View 1 chunk +0 lines, -190 lines 0 comments Download
D ash/common/system/tray/three_view_layout_unittest.cc View 1 chunk +0 lines, -342 lines 0 comments Download
M ash/common/system/tray/tray_constants.h View 1 chunk +0 lines, -12 lines 0 comments Download
M ash/common/system/tray/tray_constants.cc View 2 chunks +0 lines, -16 lines 0 comments Download
D ash/common/system/tray/tray_popup_layout_factory.h View 1 chunk +0 lines, -55 lines 0 comments Download
D ash/common/system/tray/tray_popup_layout_factory.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/views/test/test_layout_manager.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/views/test/test_layout_manager.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M ui/views/test/test_views.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/test/test_views.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/views/view.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Peter Kasting
Created Revert of Added common layout framework for system menu rows.
4 years, 2 months ago (2016-10-21 02:18:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441923004/1
4 years, 2 months ago (2016-10-21 02:19:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 02:21:20 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:26:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb262a45b811e708af8a5ec2ee0ccada3ccb2758
Cr-Commit-Position: refs/heads/master@{#426692}

Powered by Google App Engine
This is Rietveld 408576698