Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2441693003: fix #27643, failed to virtualize fields if an abstract one is mixed in (Closed)

Created:
4 years, 2 months ago by Jennifer Messerly
Modified:
4 years, 2 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27643, failed to virtualize fields if an abstract one is mixed in R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/95ef8bb59ab875dbcbbc6866bc25684b6dcced57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
M pkg/dev_compiler/lib/src/compiler/js_field_storage.dart View 1 chunk +0 lines, -4 lines 0 comments Download
A pkg/dev_compiler/test/codegen/language/mixin_abstract_getter_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/math/implement_rectangle_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 2 months ago (2016-10-20 23:12:37 UTC) #2
vsm
lgtm!
4 years, 2 months ago (2016-10-20 23:20:55 UTC) #3
Jennifer Messerly
4 years, 2 months ago (2016-10-20 23:31:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
95ef8bb59ab875dbcbbc6866bc25684b6dcced57 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698