Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: pkg/dev_compiler/lib/src/compiler/js_field_storage.dart

Issue 2441693003: fix #27643, failed to virtualize fields if an abstract one is mixed in (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/test/codegen/language/mixin_abstract_getter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/js_field_storage.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/js_field_storage.dart b/pkg/dev_compiler/lib/src/compiler/js_field_storage.dart
index decef3b8a894079cfeb42230d98dde66e47e9e2f..13d598024f4ee28b2483c0a2f7d19500d1956f2f 100644
--- a/pkg/dev_compiler/lib/src/compiler/js_field_storage.dart
+++ b/pkg/dev_compiler/lib/src/compiler/js_field_storage.dart
@@ -30,10 +30,6 @@ PropertyOverrideResult checkForPropertyOverride(
var setter = superprop.setter;
bool hasSetter = setter != null && !setter.isAbstract;
if (hasSetter) foundSetter = true;
-
- // Stop if this is an abstract getter/setter
- // TODO(jmesserly): why were we doing this?
- if (!hasGetter && !hasSetter) break;
}
return new PropertyOverrideResult(foundGetter, foundSetter);
« no previous file with comments | « no previous file | pkg/dev_compiler/test/codegen/language/mixin_abstract_getter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698