chrome/browser/password_manager/native_backend_libsecret_unittest.cc - Issue 2441653002: Always unlock all libsecret items in Password Manager and OSCrypt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 2441653002: Always unlock all libsecret items in Password Manager and OSCrypt (Closed)

Patch Set: Error handling Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret.cc ('k') | components/os_crypt/key_storage_libsecret.cc » ('j') | components/os_crypt/key_storage_libsecret.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

index e71a340a2c1d25b82202cb64e63e75cccf79e245..8f1f061b0f541d8f6f617d269e6e659af79e486a 100644

--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

@@ -129,6 +129,7 @@ GList* mock_secret_service_search_sync(SecretService* service,

SecretSearchFlags flags,

GCancellable* cancellable,

GError** error) {

+ EXPECT_TRUE(flags & SECRET_SEARCH_UNLOCK);

GList* result = nullptr;

for (MockSecretItem* item : *global_mock_libsecret_items) {

if (Matches(item, attributes))