Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6277)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 2441653002: Always unlock all libsecret items in Password Manager and OSCrypt (Closed)
Patch Set: Error handling Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | components/os_crypt/key_storage_libsecret.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/native_backend_libsecret.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc
index 6b3fab35227341c38066b61d261ad4dae46c54e6..dab55dbe895a1dad495890b1e423cab41c75cf56 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret.cc
@@ -318,7 +318,8 @@ bool NativeBackendLibsecret::AddUpdateLoginSearch(
GError* error = nullptr;
GList* found = LibsecretLoader::secret_service_search_sync(
nullptr, // default secret service
- &kLibsecretSchema, attrs.Get(), SECRET_SEARCH_ALL,
+ &kLibsecretSchema, attrs.Get(),
+ static_cast<SecretSearchFlags>(SECRET_SEARCH_ALL | SECRET_SEARCH_UNLOCK),
nullptr, // no cancellable ojbect
&error);
if (error) {
@@ -421,7 +422,8 @@ bool NativeBackendLibsecret::GetLoginsList(
GError* error = nullptr;
GList* found = LibsecretLoader::secret_service_search_sync(
nullptr, // default secret service
- &kLibsecretSchema, attrs.Get(), SECRET_SEARCH_ALL,
+ &kLibsecretSchema, attrs.Get(),
+ static_cast<SecretSearchFlags>(SECRET_SEARCH_ALL | SECRET_SEARCH_UNLOCK),
nullptr, // no cancellable ojbect
&error);
if (error) {
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | components/os_crypt/key_storage_libsecret.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698