bluetooth: Add tests for when frame reconnects during readValue

bluetooth: Add tests for when frame reconnects during readValue

Follow up patch that adds a new fake adapter that finishes a gatt operation
after a connect is called and adds tests that uses it.

Previous patch: http://crrev.com/2443473003

BUG=608538
Committed: https://crrev.com/d0873b1b6847cbec6aeb730ad8a2ee7f15c7d3bd
Cr-Commit-Position: refs/heads/master@{#427009}

[ortuno, 2016-10-21 05:33:25]

Description was changed from

==========
bluetooth: Add tests for when frame reconnects during readValue

Follow up patch that adds a new fake adapter that finishes a gatt operation
after a connect is called and adds tests that uses it.

Previous patch:

BUG=608538
==========

to

==========
bluetooth: Add tests for when frame reconnects during readValue

Follow up patch that adds a new fake adapter that finishes a gatt operation
after a connect is called and adds tests that uses it.

Previous patch: http://crrev.com/2443473003

BUG=608538
==========

[ortuno, 2016-10-21 05:49:05]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2016-10-21 05:49:06]

jyasskin: PTAL

[ortuno, 2016-10-21 05:49:12]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:49:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 06:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 06:14:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jeffrey Yasskin, 2016-10-22 01:02:06]

LGTM.

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:908:
BluetoothRemoteGattCharacteristic::PROPERTY_WRITE |
Since the characteristic only actually handles read, maybe omit write and notify
from the properties for now?

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:356:
//         - Generic Access Service - Characteristics as describe in
"as described"

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:361:
//                 otherwise it saves a failured callback. This callback
s/failured/failure/? or "succeeding" and "failing".

https://codereview.chromium.org/2438963002/diff/20001/device/bluetooth/test/m...
File device/bluetooth/test/mock_bluetooth_device.h (right):

https://codereview.chromium.org/2438963002/diff/20001/device/bluetooth/test/m...
device/bluetooth/test/mock_bluetooth_device.h:127: base::Closure
PopPendingCallback();
Consider making this RunAllCallbacks() instead. If you need a way to run one at
a time, then Pop makes sense, but I don't see it in this patch.

[ortuno, 2016-10-23 23:24:54]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 23:25:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-10-23 23:30:43]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 23:30:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-10-23 23:34:40]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 23:34:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-10-23 23:36:07]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 23:36:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 01:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 01:15:05]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-10-24 01:52:32]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-10-24 01:52:33]

Thanks!

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:908:
BluetoothRemoteGattCharacteristic::PROPERTY_WRITE |
On 2016/10/22 at 01:02:06, Jeffrey Yasskin wrote:
> Since the characteristic only actually handles read, maybe omit write and
notify from the properties for now?

Done.

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:356:
//         - Generic Access Service - Characteristics as describe in
On 2016/10/22 at 01:02:06, Jeffrey Yasskin wrote:
> "as described"

Done.

https://codereview.chromium.org/2438963002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:361:
//                 otherwise it saves a failured callback. This callback
On 2016/10/22 at 01:02:06, Jeffrey Yasskin wrote:
> s/failured/failure/? or "succeeding" and "failing".

Oops. Done.

https://codereview.chromium.org/2438963002/diff/20001/device/bluetooth/test/m...
File device/bluetooth/test/mock_bluetooth_device.h (right):

https://codereview.chromium.org/2438963002/diff/20001/device/bluetooth/test/m...
device/bluetooth/test/mock_bluetooth_device.h:127: base::Closure
PopPendingCallback();
On 2016/10/22 at 01:02:06, Jeffrey Yasskin wrote:
> Consider making this RunAllCallbacks() instead. If you need a way to run one
at a time, then Pop makes sense, but I don't see it in this patch.

Done. I also removed the HasPendingCallback function since it is no longer
needed.

[ortuno, 2016-10-24 01:52:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/2438963002/#ps60001
(title: "Address jyasskin's comments")

[commit-bot: I haz the power, 2016-10-24 01:52:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 02:03:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-24 02:06:10]

Description was changed from

==========
bluetooth: Add tests for when frame reconnects during readValue

Follow up patch that adds a new fake adapter that finishes a gatt operation
after a connect is called and adds tests that uses it.

Previous patch: http://crrev.com/2443473003

BUG=608538
==========

to

==========
bluetooth: Add tests for when frame reconnects during readValue

Follow up patch that adds a new fake adapter that finishes a gatt operation
after a connect is called and adds tests that uses it.

Previous patch: http://crrev.com/2443473003

BUG=608538

Committed: https://crrev.com/d0873b1b6847cbec6aeb730ad8a2ee7f15c7d3bd
Cr-Commit-Position: refs/heads/master@{#427009}
==========

[commit-bot: I haz the power, 2016-10-24 02:06:12]

Patchset 4 (id:??) landed as
https://crrev.com/d0873b1b6847cbec6aeb730ad8a2ee7f15c7d3bd
Cr-Commit-Position: refs/heads/master@{#427009}