DevTools: clean up scripts folder

DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Committed: https://crrev.com/970e7fbd10cce3aa686b765d31dc5024a6bdd46d
Cr-Original-Commit-Position: refs/heads/master@{#428430}
Cr-Commit-Position: refs/heads/master@{#428544}

[chenwilliam, 2016-10-21 21:54:48]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2016-10-21 21:54:49]

PTAL. It looks like a lot of diffs but it's mostly moving files around (for
consistent naming)

[dgozman, 2016-10-24 18:26:00]

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/README.md (right):

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/README.md:7: The newer scripts such
as for testing and hosted mode are written in Node.js, which has become the
standard toolchain for web apps. The older scripts such as building (e.g.
bundling and minifying) are written in Python, which has first-class support in
Chromium's infrastructure. Over time, more of the scripts will be migrated to
node.js.
Remove the last sentence :-)

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/gulp/ConcatenateProtocols.js
(right):

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/gulp/ConcatenateProtocols.js:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
Should we rename this one as well to follow snake_case?

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/jsdoc_validator/hashes (right):

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/jsdoc_validator/hashes:1:
27b455c512a9e81360ac27c0a14e7479bb18e6179ffbfa70dcee64ad49b6e7dc
jsdoc_validator.jar
Why do we have both jsdoc_validator.jar and jsdoc-validator.jar files in the
patch?

[chenwilliam, 2016-10-24 22:57:12]

PTAL. Fixed w/ your comments.

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/README.md (right):

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/README.md:7: The newer scripts such
as for testing and hosted mode are written in Node.js, which has become the
standard toolchain for web apps. The older scripts such as building (e.g.
bundling and minifying) are written in Python, which has first-class support in
Chromium's infrastructure. Over time, more of the scripts will be migrated to
node.js.
On 2016/10/24 18:26:00, dgozman wrote:
> Remove the last sentence :-)

Done.

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/gulp/ConcatenateProtocols.js
(right):

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/gulp/ConcatenateProtocols.js:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
On 2016/10/24 18:26:00, dgozman wrote:
> Should we rename this one as well to follow snake_case?

Done.

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/jsdoc_validator/hashes (right):

https://codereview.chromium.org/2441163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/jsdoc_validator/hashes:1:
27b455c512a9e81360ac27c0a14e7479bb18e6179ffbfa70dcee64ad49b6e7dc
jsdoc_validator.jar
On 2016/10/24 18:26:00, dgozman wrote:
> Why do we have both jsdoc_validator.jar and jsdoc-validator.jar files in the
> patch?

My mistake, I've removed jsdoc-validator.jar.

[dgozman, 2016-10-24 23:47:53]

lgtm

[chenwilliam, 2016-10-25 17:23:11]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:23:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 17:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:34:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chenwilliam, 2016-10-25 19:19:50]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
NOPRESUBMIT=true
==========

[chenwilliam, 2016-10-25 19:29:34]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
NOPRESUBMIT=true
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
==========

[chenwilliam, 2016-10-25 19:31:15]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-10-25 19:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2441163002/#ps40001
(title: "reformat + rebuild jars")

[commit-bot: I haz the power, 2016-10-25 19:32:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 19:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 19:42:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chenwilliam, 2016-10-25 22:38:02]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-10-25 22:38:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2441163002/#ps60001
(title: "rebuild jsdoc jar")

[commit-bot: I haz the power, 2016-10-25 22:38:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chenwilliam, 2016-10-25 22:46:46]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
NOPRESUBMIT=true
==========

[chenwilliam, 2016-10-25 22:47:07]

The CQ bit was unchecked by chenwilliam@chromium.org

[chenwilliam, 2016-10-25 22:47:38]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-10-25 22:48:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 22:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 22:54:01]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chenwilliam, 2016-10-25 23:36:36]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-10-25 23:36:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2441163002/#ps80001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-10-25 23:37:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chenwilliam, 2016-10-25 23:48:00]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
NOPRESUBMIT=true
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
==========

[chenwilliam, 2016-10-25 23:48:10]

The CQ bit was unchecked by chenwilliam@chromium.org

[chenwilliam, 2016-10-25 23:48:32]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:48:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:51:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chenwilliam, 2016-10-26 00:23:09]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[chenwilliam, 2016-10-26 00:24:32]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[chenwilliam, 2016-10-26 00:24:32]

chenwilliam@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[chenwilliam, 2016-10-26 00:28:52]

dmazzoni - Can you review the change in chromevox/run_jsbundler.gni?

I updated the chromevox/run_jsbundler.gni reference to rjsmin.py because I'm
cleaning up devtools scripts directory.

It seems odd to me that chromevox is referencing devtools minification script.
Perhaps chromevox should have its own copy of the python script? For now though,
I'd like to update the gni reference so this can compile on the ChromeOS CQ
trybots.

[dmazzoni, 2016-10-27 19:41:26]

On 2016/10/26 00:28:52, chenwilliam wrote:
> dmazzoni - Can you review the change in chromevox/run_jsbundler.gni?
> 
> I updated the chromevox/run_jsbundler.gni reference to rjsmin.py because I'm
> cleaning up devtools scripts directory.
> 
> It seems odd to me that chromevox is referencing devtools minification script.
> Perhaps chromevox should have its own copy of the python script? For now
though,
> I'd like to update the gni reference so this can compile on the ChromeOS CQ
> trybots.

Perhaps it should be moved to a general directory that other parts of the code
could depend on? There's nothing devtools-specific about it, right?

[dmazzoni, 2016-10-27 19:41:31]

lgtm

[chenwilliam, 2016-10-27 20:45:25]

On 2016/10/27 19:41:26, dmazzoni wrote:
> On 2016/10/26 00:28:52, chenwilliam wrote:
> > dmazzoni - Can you review the change in chromevox/run_jsbundler.gni?
> > 
> > I updated the chromevox/run_jsbundler.gni reference to rjsmin.py because I'm
> > cleaning up devtools scripts directory.
> > 
> > It seems odd to me that chromevox is referencing devtools minification
script.
> > Perhaps chromevox should have its own copy of the python script? For now
> though,
> > I'd like to update the gni reference so this can compile on the ChromeOS CQ
> > trybots.
> 
> Perhaps it should be moved to a general directory that other parts of the code
> could depend on? There's nothing devtools-specific about it, right?

True, I don't think there's anything devtools-specific about it. The benefit for
us keeping it in devtools directory is that we have a git subtree mirror for our
devtools frontend on GitHub and we're working on being able to compile devtools
front-end with only the subtree checkout. It's not ideal, but chromevox could
have its own copy of rjsmin.py which is what other projects have done in
chromium:
https://cs.chromium.org/search/?q=rjsmin.py&sq=package:chromium&type=cs

[chenwilliam, 2016-10-27 20:52:59]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-10-27 20:53:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2441163002/#ps120001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-10-27 20:53:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:05:54]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chenwilliam, 2016-10-27 22:21:26]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:22:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:23:24]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chenwilliam, 2016-10-27 23:52:32]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:52:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 01:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:21:12]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chenwilliam, 2016-10-28 17:41:51]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-10-28 17:42:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:19:08]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-28 18:19:10]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-28 18:22:44]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Cr-Commit-Position: refs/heads/master@{#428430}
==========

[commit-bot: I haz the power, 2016-10-28 18:22:46]

Patchset 7 (id:??) landed as
https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Cr-Commit-Position: refs/heads/master@{#428430}

[xidachen, 2016-10-28 20:36:08]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2464463002/ by xidachen@chromium.org.

The reason for reverting is: Causing compile error here:
https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge....

[chenwilliam, 2016-10-28 21:12:48]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Cr-Commit-Position: refs/heads/master@{#428430}
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Cr-Commit-Position: refs/heads/master@{#428430}
==========

[chenwilliam, 2016-10-28 21:12:59]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-10-28 21:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2441163002/#ps140001
(title: "Fix sys.path for chromevox to load rjsmin")

[commit-bot: I haz the power, 2016-10-28 21:13:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 23:31:05]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Cr-Commit-Position: refs/heads/master@{#428430}
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Cr-Commit-Position: refs/heads/master@{#428430}
==========

[commit-bot: I haz the power, 2016-10-28 23:31:08]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-10-28 23:37:53]

Description was changed from

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Cr-Commit-Position: refs/heads/master@{#428430}
==========

to

==========
DevTools: clean up scripts folder

- Use consistent snake_case naming for folders and files
- Move Python build scripts to scripts/build
- Add description in readme.md
- Rename js_build -> gulp

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e
Committed: https://crrev.com/970e7fbd10cce3aa686b765d31dc5024a6bdd46d
Cr-Original-Commit-Position: refs/heads/master@{#428430}
Cr-Commit-Position: refs/heads/master@{#428544}
==========

[commit-bot: I haz the power, 2016-10-28 23:37:54]

Patchset 8 (id:??) landed as
https://crrev.com/970e7fbd10cce3aa686b765d31dc5024a6bdd46d
Cr-Commit-Position: refs/heads/master@{#428544}