Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java

Issue 2441163002: DevTools: clean up scripts folder (Closed)
Patch Set: Fix sys.path for chromevox to load rjsmin Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
diff --git a/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java b/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
similarity index 64%
rename from third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
rename to third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
index 94bec2c7d64a8096625d0a8d8562f4d2da4982c1..b14ab5a9f53e8e9a5609a22529dc8b55d105359c 100644
--- a/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
+++ b/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java
@@ -10,7 +10,6 @@ import java.util.Collections;
import java.util.List;
public class AstUtil {
-
private static final String PROTOTYPE_SUFFIX = ".prototype";
static Node parentOfType(Node node, int tokenType) {
@@ -27,29 +26,29 @@ public class AstUtil {
Node parent = node.getParent();
if (parent != null) {
switch (parent.getType()) {
- case Token.NAME:
- // var name = function() ...
- // var name2 = function name1() ...
- return parent;
- // FIXME: Enable the setter and getter checks.
- // case Token.SETTER_DEF:
- // case Token.GETTER_DEF:
- case Token.STRING_KEY:
- return parent;
- case Token.NUMBER:
- return parent;
- case Token.ASSIGN:
- int nameType = parent.getFirstChild().getType();
- // We only consider these types of name nodes as acceptable.
- return nameType == Token.NAME || nameType == Token.GETPROP
- ? parent.getFirstChild()
- : null;
- case Token.VAR:
- return parent.getFirstChild();
- default:
- Node funNameNode = node.getFirstChild();
- // Don't return the name node for anonymous functions
- return funNameNode.getString().isEmpty() ? null : funNameNode;
+ case Token.NAME:
+ // var name = function() ...
+ // var name2 = function name1() ...
+ return parent;
+ // FIXME: Enable the setter and getter checks.
+ // case Token.SETTER_DEF:
+ // case Token.GETTER_DEF:
+ case Token.STRING_KEY:
+ return parent;
+ case Token.NUMBER:
+ return parent;
+ case Token.ASSIGN:
+ int nameType = parent.getFirstChild().getType();
+ // We only consider these types of name nodes as acceptable.
+ return nameType == Token.NAME || nameType == Token.GETPROP
+ ? parent.getFirstChild()
+ : null;
+ case Token.VAR:
+ return parent.getFirstChild();
+ default:
+ Node funNameNode = node.getFirstChild();
+ // Don't return the name node for anonymous functions
+ return funNameNode.getString().isEmpty() ? null : funNameNode;
}
}

Powered by Google App Engine
This is Rietveld 408576698