Index: scripts/slave/recipe_modules/auto_bisect/revision_state.py |
diff --git a/scripts/slave/recipe_modules/auto_bisect/revision_state.py b/scripts/slave/recipe_modules/auto_bisect/revision_state.py |
index b5d40748acf14d58d512da380065ebe988130386..9e198278594eb121c4a0017e24ddfd9da885cc0c 100644 |
--- a/scripts/slave/recipe_modules/auto_bisect/revision_state.py |
+++ b/scripts/slave/recipe_modules/auto_bisect/revision_state.py |
@@ -297,12 +297,16 @@ class RevisionState(object): |
def _is_build_failed(self): |
api = self.bisector.api |
- result = api.m.buildbucket.get_build( |
- self.build_id, |
- api.m.service_account.get_json_path(api.SERVICE_ACCOUNT), |
- step_test_data=lambda: api.m.json.test_api.output_stream( |
- {'build': {'result': 'SUCCESS', 'status': 'COMPLETED'}} |
- )) |
+ try: |
+ result = api.m.buildbucket.get_build( |
+ self.build_id, |
+ api.m.service_account.get_json_path(api.SERVICE_ACCOUNT), |
+ step_test_data=lambda: api.m.json.test_api.output_stream( |
+ {'build': {'result': 'SUCCESS', 'status': 'COMPLETED'}} |
+ )) |
+ except api.m.step.StepFailure: # pragma: no cover |
+ # If the check fails, we cannot assume that the build is failed. |
prasadv1
2016/10/21 21:37:17
What should happen when buildbucket.get() fails an
|
+ return False |
return (result.stdout['build']['status'] == 'COMPLETED' and |
result.stdout['build'].get('result') != 'SUCCESS') |