Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/revision_state.py

Issue 2441143002: Make bisect not break when buildbucket.get fails. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect_staging/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/revision_state.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/revision_state.py b/scripts/slave/recipe_modules/auto_bisect/revision_state.py
index b5d40748acf14d58d512da380065ebe988130386..9e198278594eb121c4a0017e24ddfd9da885cc0c 100644
--- a/scripts/slave/recipe_modules/auto_bisect/revision_state.py
+++ b/scripts/slave/recipe_modules/auto_bisect/revision_state.py
@@ -297,12 +297,16 @@ class RevisionState(object):
def _is_build_failed(self):
api = self.bisector.api
- result = api.m.buildbucket.get_build(
- self.build_id,
- api.m.service_account.get_json_path(api.SERVICE_ACCOUNT),
- step_test_data=lambda: api.m.json.test_api.output_stream(
- {'build': {'result': 'SUCCESS', 'status': 'COMPLETED'}}
- ))
+ try:
+ result = api.m.buildbucket.get_build(
+ self.build_id,
+ api.m.service_account.get_json_path(api.SERVICE_ACCOUNT),
+ step_test_data=lambda: api.m.json.test_api.output_stream(
+ {'build': {'result': 'SUCCESS', 'status': 'COMPLETED'}}
+ ))
+ except api.m.step.StepFailure: # pragma: no cover
+ # If the check fails, we cannot assume that the build is failed.
prasadv1 2016/10/21 21:37:17 What should happen when buildbucket.get() fails an
+ return False
return (result.stdout['build']['status'] == 'COMPLETED' and
result.stdout['build'].get('result') != 'SUCCESS')
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect_staging/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698