chrome/browser/resources/settings/settings_page/settings_subpage.html - Issue 2441043004: Accessibility fixes for quick unlock settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 2441043004: Accessibility fixes for quick unlock settings. (Closed)

Patch Set: Address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/setup_pin_dialog.js ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_subpage.html

diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage.html b/chrome/browser/resources/settings/settings_page/settings_subpage.html

index c0296af68e0a22f5690ac9128cd238cb6decabd8..0e8a18d35f38cd816257d1d86c58e14ee53a728c 100644

--- a/chrome/browser/resources/settings/settings_page/settings_subpage.html

+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.html

@@ -42,7 +42,8 @@

}

</style>

- <paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_">

+ <paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_"

+ alt="$i18n{back}">

Dan Beam 2016/11/01 00:12:09 why are you using alt= here? that's an <img> thin

jdufault 2016/11/08 23:29:12 Done.

</paper-icon-button>

<h1>[[pageTitle]]</h1>