chrome/browser/resources/settings/settings_page/settings_subpage.html - Issue 2441043004: Accessibility fixes for quick unlock settings.

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 2441043004: Accessibility fixes for quick unlock settings. (Closed)

Patch Set: Address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/browser/resources/settings/people_page/setup_pin_dialog.js ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

5 <link rel="import" href="/icons.html">	5 <link rel="import" href="/icons.html">

6 <link rel="import" href="/route.html">	6 <link rel="import" href="/route.html">

7 <link rel="import" href="/settings_page/settings_subpage_search.html">	7 <link rel="import" href="/settings_page/settings_subpage_search.html">

8 <link rel="import" href="/settings_shared_css.html">	8 <link rel="import" href="/settings_shared_css.html">

9	9

10 <dom-module id="settings-subpage">	10 <dom-module id="settings-subpage">

(...skipping 24 matching lines...) Expand all Loading...
35 flex: 1; /* Push other items to the end. */	35 flex: 1; /* Push other items to the end. */

36 font-size: 107.6923%; /* Go to 14px from 13px */	36 font-size: 107.6923%; /* Go to 14px from 13px */

37 font-weight: 500;	37 font-weight: 500;

38 }	38 }

39	39

40 settings-subpage-search {	40 settings-subpage-search {

41 -webkit-margin-start: auto;	41 -webkit-margin-start: auto;

42 }	42 }

43 </style>	43 </style>

44 <div class="settings-box first">	44 <div class="settings-box first">

45 <paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_">	45 <paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_"

	46 alt="$i18n{back}">
	Dan Beam 2016/11/01 00:12:09 why are you using alt= here? that's an <img> thin why are you using alt= here? that's an <img> thing. can you use title= or aria-description? jdufault 2016/11/08 23:29:12 Done. Show quoted text On 2016/11/01 00:12:09, Dan Beam wrote: > why are you using alt= here? that's an <img> thing. can you use title= or > aria-description? Done.
46 </paper-icon-button>	47 </paper-icon-button>

47 <h1>[[pageTitle]]</h1>	48 <h1>[[pageTitle]]</h1>

48 <template is="dom-if" if="[[searchLabel]]">	49 <template is="dom-if" if="[[searchLabel]]">

49 <settings-subpage-search label="[[searchLabel]]"	50 <settings-subpage-search label="[[searchLabel]]"

50 on-search-changed="onSearchChanged_">	51 on-search-changed="onSearchChanged_">

51 </settings-subpage-search>	52 </settings-subpage-search>

52 </template>	53 </template>

53 <content select=".subpage-title-extra"></content>	54 <content select=".subpage-title-extra"></content>

54 </div>	55 </div>

55 <content></content>	56 <content></content>

56 </template>	57 </template>

57 <script src="settings_subpage.js"></script>	58 <script src="settings_subpage.js"></script>

58 </dom-module>	59 </dom-module>

OLD	NEW