chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2441043004: Accessibility fixes for quick unlock settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2441043004: Accessibility fixes for quick unlock settings. (Closed)

Patch Set: Address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_subpage.html ('k') | chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js » ('j') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 396948d604916b851a8b4e3f5a36c656f03ee1fa..00afb6cbbd7e10cf151ee82977aca9e94f9b15e0 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -67,7 +67,9 @@ void AddLocalizedStringsBulk(content::WebUIDataSource* html_source,

void AddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) {

LocalizedString localized_strings[] = {

{"add", IDS_ADD},

+ {"back", IDS_BACK},

{"cancel", IDS_CANCEL},

+ {"close", IDS_CLOSE},

Dan Beam 2016/10/27 00:31:37 yeah, don't add a message here and assume it's alw

jdufault 2016/10/27 19:13:55 Is there a better place to inject it?

{"confirm", IDS_CONFIRM},

{"disable", IDS_DISABLE},

{"learnMore", IDS_LEARN_MORE},