Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2441043004: Accessibility fixes for quick unlock settings. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/i18n/number_formatting.h" 10 #include "base/i18n/number_formatting.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 size_t num_strings) { 60 size_t num_strings) {
61 for (size_t i = 0; i < num_strings; i++) { 61 for (size_t i = 0; i < num_strings; i++) {
62 html_source->AddLocalizedString(localized_strings[i].name, 62 html_source->AddLocalizedString(localized_strings[i].name,
63 localized_strings[i].id); 63 localized_strings[i].id);
64 } 64 }
65 } 65 }
66 66
67 void AddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) { 67 void AddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) {
68 LocalizedString localized_strings[] = { 68 LocalizedString localized_strings[] = {
69 {"add", IDS_ADD}, 69 {"add", IDS_ADD},
70 {"back", IDS_BACK},
70 {"cancel", IDS_CANCEL}, 71 {"cancel", IDS_CANCEL},
72 {"close", IDS_CLOSE},
Dan Beam 2016/10/27 00:31:37 yeah, don't add a message here and assume it's alw
jdufault 2016/10/27 19:13:55 Is there a better place to inject it?
71 {"confirm", IDS_CONFIRM}, 73 {"confirm", IDS_CONFIRM},
72 {"disable", IDS_DISABLE}, 74 {"disable", IDS_DISABLE},
73 {"learnMore", IDS_LEARN_MORE}, 75 {"learnMore", IDS_LEARN_MORE},
74 {"ok", IDS_OK}, 76 {"ok", IDS_OK},
75 {"save", IDS_SAVE}, 77 {"save", IDS_SAVE},
76 {"advancedPageTitle", IDS_SETTINGS_ADVANCED}, 78 {"advancedPageTitle", IDS_SETTINGS_ADVANCED},
77 {"basicPageTitle", IDS_SETTINGS_BASIC}, 79 {"basicPageTitle", IDS_SETTINGS_BASIC},
78 {"settings", IDS_SETTINGS_SETTINGS}, 80 {"settings", IDS_SETTINGS_SETTINGS},
79 {"restart", IDS_SETTINGS_RESTART}, 81 {"restart", IDS_SETTINGS_RESTART},
80 {"menuButtonLabel", IDS_SETTINGS_MENU_BUTTON_LABEL}, 82 {"menuButtonLabel", IDS_SETTINGS_MENU_BUTTON_LABEL},
(...skipping 1655 matching lines...) Expand 10 before | Expand all | Expand 10 after
1736 #endif 1738 #endif
1737 AddUsersStrings(html_source); 1739 AddUsersStrings(html_source);
1738 AddWebContentStrings(html_source); 1740 AddWebContentStrings(html_source);
1739 1741
1740 policy_indicator::AddLocalizedStrings(html_source); 1742 policy_indicator::AddLocalizedStrings(html_source);
1741 1743
1742 html_source->SetJsonPath(kLocalizedStringsFile); 1744 html_source->SetJsonPath(kLocalizedStringsFile);
1743 } 1745 }
1744 1746
1745 } // namespace settings 1747 } // namespace settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698