Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2441043003: A few more cleanups to overview mode code related to the pre-MD version. (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
tdanderson, varkha
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A few more cleanups to overview mode code related to the pre-MD version. BUG=633986 Committed: https://crrev.com/b5c0820644a3f5cfac8a60b91b2555c8d2123481 Cr-Commit-Position: refs/heads/master@{#427122}

Patch Set 1 #

Messages

Total messages: 19 (10 generated)
Evan Stade
4 years, 2 months ago (2016-10-21 19:41:45 UTC) #3
varkha
lgtm
4 years, 1 month ago (2016-10-24 14:40:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441043003/1
4 years, 1 month ago (2016-10-24 17:42:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/287922)
4 years, 1 month ago (2016-10-24 18:07:05 UTC) #11
Evan Stade
+tdanderson for resource deletion
4 years, 1 month ago (2016-10-24 18:46:08 UTC) #13
tdanderson
lgtm
4 years, 1 month ago (2016-10-24 18:49:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441043003/1
4 years, 1 month ago (2016-10-24 19:25:39 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 19:44:22 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 19:55:55 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5c0820644a3f5cfac8a60b91b2555c8d2123481
Cr-Commit-Position: refs/heads/master@{#427122}

Powered by Google App Engine
This is Rietveld 408576698