Issue 244103002: DevTools: handle search view shortcuts before editor shortcuts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 244103002: DevTools: handle search view shortcuts before editor shortcuts (Closed)

Created:
6 years, 8 months ago by lushnikov

Modified:
6 years, 8 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: handle search view shortcuts before editor shortcuts This patch changes order of shortcut handling, setting search view shourtcuts to be handled on event capturing and thus before text editor. BUG=365086

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/devtools/front_end/SearchableView.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsevik

On 2014/04/19 12:38:17, lushnikov wrote: > Please take a look. Doe sit mean that closing ...

6 years, 8 months ago (2014-04-21 11:26:56 UTC) #2

lushnikov

6 years, 8 months ago (2014-04-21 12:22:31 UTC) #3

On 2014/04/21 11:26:56, vsevik wrote:
> On 2014/04/19 12:38:17, lushnikov wrote:
> > Please take a look.
> Doe sit mean that closing search pane has higher priority than any actions
> inside the searchable view (e.g. closing autocomplete cuggestions or closing
> edit as html dialog in elements panel)?
> This is weird.

Close the patch due to offline discussion.

Expand Messages | Collapse Messages