Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2440943002:
[heap] Enable black allocation when finalizing marking. (Closed)
|
Created:
4 years, 2 months ago by Hannes Payer (out of office) Modified:
4 years ago Reviewers:
ulan CC:
v8-reviews_googlegroups.com, Michael Hablich Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Enable black allocation when finalizing marking.
BUG=chromium:630386
Committed: https://crrev.com/a98d971412a5c32967bbef4b77b9d2658055ff1c
Cr-Commit-Position: refs/heads/master@{#41655}
Patch Set 1 #Patch Set 2 : fix live bytes #Patch Set 3 : flag #Messages
Total messages: 23 (18 generated)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ulan@chromium.org changed reviewers: + ulan@chromium.org
lgtm :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hpayer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2440943002/#ps40001 (title: "flag")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481572302442290,
"parent_rev": "2ef35023009d27c1f0c8007d1026585739d863c4", "commit_rev":
"9153eb1a894209fc2b87d343721fa875a6127fd4"}
Message was sent while issue was closed.
Description was changed from ========== [heap] Enable black allocation when finalizing marking. BUG=chromium:630386 ========== to ========== [heap] Enable black allocation when finalizing marking. BUG=chromium:630386 Review-Url: https://codereview.chromium.org/2440943002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Enable black allocation when finalizing marking. BUG=chromium:630386 Review-Url: https://codereview.chromium.org/2440943002 ========== to ========== [heap] Enable black allocation when finalizing marking. BUG=chromium:630386 Committed: https://crrev.com/a98d971412a5c32967bbef4b77b9d2658055ff1c Cr-Commit-Position: refs/heads/master@{#41655} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a98d971412a5c32967bbef4b77b9d2658055ff1c Cr-Commit-Position: refs/heads/master@{#41655}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2567353002/ by machenbach@chromium.org. The reason for reverting is: Seems to block roll: https://codereview.chromium.org/2569133002/. |
