Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 244093002: x11: Make the event-source work with both glib and libevent message-pumps. (Closed)

Created:
6 years, 8 months ago by sadrul
Modified:
6 years, 8 months ago
CC:
chromium-reviews, ben+aura_chromium.org, erikwright+watch_chromium.org, kalyank
Visibility:
Public.

Description

x11: Make the event-source work with both glib and libevent message-pumps. Split up the X11EventSource into X11EventSourceGlib to work with the glib message-pump, and X11EventSourceLibevent to work with the libevent message-pump. With this change, it is possible to build and run chromeos without glib (use_glib = 0). BUG=354062, 240715 R=darin@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265007

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot-merge #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -83 lines) Patch
M base/message_loop/message_loop.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/events.gyp View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M ui/events/platform/x11/x11_event_source.h View 1 chunk +3 lines, -9 lines 0 comments Download
M ui/events/platform/x11/x11_event_source.cc View 5 chunks +1 line, -69 lines 0 comments Download
A ui/events/platform/x11/x11_event_source_glib.cc View 1 1 chunk +101 lines, -0 lines 0 comments Download
A ui/events/platform/x11/x11_event_source_libevent.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
sky@: Please review chrome/ and ui/ changes. darin@: please review base/ changes. Do you know ...
6 years, 8 months ago (2014-04-19 19:17:44 UTC) #1
darin (slow to review)
LGTM for base/ I think OS_NACL just really wants to use the default message pump ...
6 years, 8 months ago (2014-04-20 21:24:26 UTC) #2
sky
LGTM
6 years, 8 months ago (2014-04-21 15:51:08 UTC) #3
sadrul
6 years, 8 months ago (2014-04-21 16:24:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r265007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698