Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: services/service_manager/tests/connect/connect_unittest.cc

Issue 2440903002: Make "all user" services work when packaged. (Closed)
Patch Set: Fixed other tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/tests/connect/connect_unittest.cc
diff --git a/services/service_manager/tests/connect/connect_unittest.cc b/services/service_manager/tests/connect/connect_unittest.cc
index 2cef2a2ca814609bd392fbdd0e963610f9dfe3bf..7a366137802d9ec7578c75beacae38de8199fabc 100644
--- a/services/service_manager/tests/connect/connect_unittest.cc
+++ b/services/service_manager/tests/connect/connect_unittest.cc
@@ -214,8 +214,7 @@ TEST_F(ConnectTest, Instances) {
// LifecycleTest.PackagedApp_CrashCrashesOtherProvidedApp).
TEST_F(ConnectTest, PreferUnresolvedDefaultInstanceName) {
// Connect to an app with no manifest-supplied instance name provided by a
- // package, the instance name must be derived from the application instance
- // name, not the package.
+ // package, the instance name should be empty.
std::unique_ptr<Connection> connection = connector()->Connect(kTestAppName);
{
base::RunLoop loop;
@@ -231,7 +230,7 @@ TEST_F(ConnectTest, PreferUnresolvedDefaultInstanceName) {
service->GetInstance(base::Bind(&ReceiveOneString, &instance, &loop));
loop.Run();
}
- EXPECT_EQ(GetNamePath(kTestAppName), instance);
+ EXPECT_EQ("", instance);
}
// BlockedInterface should not be exposed to this application because it is not

Powered by Google App Engine
This is Rietveld 408576698