Make "all user" services work when packaged.

services/service_manager/tests/connect/connect_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 
@@ skipping 190 matching lines @@
   {
     connection_b->GetInterface(&service_b);
     base::RunLoop loop;
     service_b->GetInstance(base::Bind(&ReceiveOneString, &instance_b, &loop));
     loop.Run();
   }
 
   EXPECT_NE(instance_a1, instance_b);
 }
 
 // When both the unresolved and resolved instance names are their default

[Jay Civelli, 2016/10/21 19:19:23]

@rockot Do you think this test should go entirely?

[Ken Rockot(use gerrit already), 2016/10/21 19:52:33]

Yeah, seems reasonable to delete this.

[Jay Civelli, 2016/10/21 20:48:33]

Removed.

 // values, the instance name from the unresolved name must be used.
 // (The case where the instance names differ is covered by
 // LifecycleTest.PackagedApp_CrashCrashesOtherProvidedApp).
 TEST_F(ConnectTest, PreferUnresolvedDefaultInstanceName) {
   // Connect to an app with no manifest-supplied instance name provided by a
-  // package, the instance name must be derived from the application instance
-  // name, not the package.
+  // package, the instance name should be empty.
   std::unique_ptr<Connection> connection = connector()->Connect(kTestAppName);
   {
     base::RunLoop loop;
     connection->AddConnectionCompletedClosure(base::Bind(&QuitLoop, &loop));
     loop.Run();
   }
 
   std::string instance;
   {
     test::mojom::ConnectTestServicePtr service;
     connection->GetInterface(&service);
     base::RunLoop loop;
     service->GetInstance(base::Bind(&ReceiveOneString, &instance, &loop));
     loop.Run();
   }
-  EXPECT_EQ(GetNamePath(kTestAppName), instance);
+  EXPECT_EQ("", instance);
 }
 
 // BlockedInterface should not be exposed to this application because it is not
 // in our CapabilityFilter whitelist.
 TEST_F(ConnectTest, BlockedInterface) {
   std::unique_ptr<Connection> connection = connector()->Connect(kTestAppName);
   base::RunLoop run_loop;
   test::mojom::BlockedInterfacePtr blocked;
   connection->GetInterface(&blocked);
   blocked.set_connection_error_handler(base::Bind(&QuitLoop, &run_loop));
@@ skipping 165 matching lines @@
     base::RunLoop loop;
     inherit_connection->AddConnectionCompletedClosure(
         base::Bind(&QuitLoop, &loop));
     loop.Run();
     EXPECT_EQ(inherit_connection->GetRemoteIdentity().user_id(),
               connection->GetRemoteIdentity().user_id());
   }
 }
 
 }  // namespace service_manager