fix #27642, static members should now work

pkg/dev_compiler/lib/src/compiler/code_generator.dart

Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
index 221d94ca9bdec9c773ecbd8bd8371ab22c711948..ac93989682e427cdea8084557adef00506dfab15 100644
--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart
+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
@@ -4659,7 +4659,10 @@ class CodeGenerator extends GeneralizingAstVisitor
 
   JS.Expression _emitAccessInternal(Expression target, Element member,
       String memberName, List<JS.Expression> typeArgs) {
-    bool isStatic = member is ClassMemberElement && member.isStatic;
+    // TODO(jmesserly): we don't use member.isStatic because it doesn't seem to
+    // work, see https://github.com/dart-lang/sdk/issues/27642 for context.
+    bool isStatic = target is SimpleIdentifier &&
+        target.staticElement is TypeDefiningElement;

[vsm, 2016/10/21 02:07:16]

Hmm, do we need target is SimpleIdentifier?

Might have:

foo.A.x;

where foo is a library prefix.

[Jennifer Messerly, 2016/10/21 17:48:07]

yes, we need something. You can't get a staticElement from an Expression
yes, I believe this is handled by _emitAccess and is why tests passed, but I
will double check. If not, we can also add a "target is PrefixedIdentifier"
branch.

     var name = _emitMemberName(memberName,
         type: getStaticType(target), isStatic: isStatic);
     if (isDynamicInvoke(target)) {