Revert of Accessibility: Ignore all anonymous blocks

Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of https://codereview.chromium.org/2387533003/ )

Reason for revert:
crbug.com/658045

Original issue's description:
> Accessibility: Ignore all anonymous blocks
>
> Anonymous blocks are an implementation detail of the
> Blink layout tree. They're surprising and not useful in
> the accessibility tree. Get rid of them by marking them
> all as ignored.
>
> While it may seem counterintuitive, this is actually
> part of a longer-term plan to get rid of the idea of
> ignoring nodes for accessibility, this will bring us
> closer to just exposing the DOM tree plus generated
> content, like FIrefox and IE do.
>
> The code change here is tiny, most of the change is
> rebasing or updating dozens and dozens of affected
> tests. I deleted a couple of tests that specifically
> tested corner cases involving anonymous blocks;
> the whole point of this change is to not make this a
> special case anymore.
>
> Also updates this script, designed to automatically
> pull test output from try servers to a local change:
>
> tools/accessibility/rebase_dump_accessibility_tree_test.py
>
> BUG=651614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e4db7ae216888672805a38d8f8fee54c836357c9
Cr-Commit-Position: refs/heads/master@{#426736}

[David Tseng, 2016-10-20 22:36:25]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-20 22:36:26]

Created Revert of Accessibility: Ignore all anonymous blocks

[commit-bot: I haz the power, 2016-10-20 22:37:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 00:33:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 00:33:47]

Failed to apply patch for
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs:
While running git apply --index -3 -p1;
  <stdin>:12: trailing whitespace.
        
  <stdin>:13: trailing whitespace.
       
  <stdin>:22: trailing whitespace.
      
  error: patch failed:
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs:325
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs'
with conflicts.
  U
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
  warning: 3 lines add whitespace errors.

Patch:      
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
Index:
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
diff --git
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
index
584fd8064f4b9b8fb76800bfd535feb36242c5e0..534079fb0947c80c080cb3bdfae27530d5467624
100644
---
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
+++
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
@@ -260,8 +260,8 @@
           {value: undefined, index: 0}, {value: undefined, index: 5}],
   ], this.RANGE);
 });
-
-
+      
+     
 TEST_F('CursorsTest', 'LineRange', function() {
   this.runCursorMovesOnDocument(this.simpleDoc, [
         [LINE, FORWARD, {value: 'end', index: 0}, {value: 'end', index: 3}],
@@ -289,7 +289,7 @@
     cursor = cursor.move(NODE, DIRECTIONAL, BACKWARD);
     assertEquals('staticText', cursor.node.role);
     assertEquals('start diff line', cursor.node.name);
-
+    
     assertEquals('inlineTextBox', cursor.node.firstChild.role);
     assertEquals('start ', cursor.node.firstChild.name);
     assertEquals('diff ', cursor.node.firstChild.nextSibling.name);
@@ -325,7 +325,7 @@
 
 TEST_F('CursorsTest', 'SingleDocSelection', function() {
   this.runWithLoadedTree(function() {/*!
-    <p><a href="google.com">google home page</a></p>
+    <a href="google.com">google home page</a>
     <p>some more text</p>
     <p>end of text</p>
   */},

[David Tseng, 2016-10-21 00:59:53]

Description was changed from

==========
Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of
https://codereview.chromium.org/2387533003/ )

Reason for revert:
crbug.com/658045

Original issue's description:
> Accessibility: Ignore all anonymous blocks
> 
> Anonymous blocks are an implementation detail of the
> Blink layout tree. They're surprising and not useful in
> the accessibility tree. Get rid of them by marking them
> all as ignored.
> 
> While it may seem counterintuitive, this is actually
> part of a longer-term plan to get rid of the idea of
> ignoring nodes for accessibility, this will bring us
> closer to just exposing the DOM tree plus generated
> content, like FIrefox and IE do.
> 
> The code change here is tiny, most of the change is
> rebasing or updating dozens and dozens of affected
> tests. I deleted a couple of tests that specifically
> tested corner cases involving anonymous blocks;
> the whole point of this change is to not make this a
> special case anymore.
> 
> Also updates this script, designed to automatically
> pull test output from try servers to a local change:
> 
> tools/accessibility/rebase_dump_accessibility_tree_test.py
> 
> BUG=651614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651614
==========

to

==========
Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of
https://codereview.chromium.org/2387533003/ )

Reason for revert:
crbug.com/658045

Original issue's description:
> Accessibility: Ignore all anonymous blocks
> 
> Anonymous blocks are an implementation detail of the
> Blink layout tree. They're surprising and not useful in
> the accessibility tree. Get rid of them by marking them
> all as ignored.
> 
> While it may seem counterintuitive, this is actually
> part of a longer-term plan to get rid of the idea of
> ignoring nodes for accessibility, this will bring us
> closer to just exposing the DOM tree plus generated
> content, like FIrefox and IE do.
> 
> The code change here is tiny, most of the change is
> rebasing or updating dozens and dozens of affected
> tests. I deleted a couple of tests that specifically
> tested corner cases involving anonymous blocks;
> the whole point of this change is to not make this a
> special case anymore.
> 
> Also updates this script, designed to automatically
> pull test output from try servers to a local change:
> 
> tools/accessibility/rebase_dump_accessibility_tree_test.py
> 
> BUG=651614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-21 01:00:06]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:00:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 01:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:05:26]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[David Tseng, 2016-10-21 01:15:03]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:15:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-10-21 01:20:44]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:21:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 03:50:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 03:50:27]

Failed to apply patch for
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs:326
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs'
with conflicts.
  U
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

Patch:      
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
Index:
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
diff --git
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
index
ff176e1acaca7365033a4489d1e084a17a96b8f4..2e3394c75ae27eb6bcef160ab540e9740b491b2e
100644
---
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
+++
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
@@ -261,7 +261,6 @@ TEST_F('CursorsTest', 'WordRange', function() {
   ], this.RANGE);
 });
 
-
 TEST_F('CursorsTest', 'LineRange', function() {
   this.runCursorMovesOnDocument(this.simpleDoc, [
         [LINE, FORWARD, {value: 'end', index: 0}, {value: 'end', index: 3}],
@@ -326,7 +325,7 @@ TEST_F('CursorsTest', 'IsInWebRange', function() {
 TEST_F('CursorsTest', 'SingleDocSelection', function() {
   this.runWithLoadedTree(function() {/*!
     <span>start</span>
-    <p><a href="google.com">google home page</a></p>
+    <a href="google.com">google home page</a>
     <p>some more text</p>
     <p>end of text</p>
   */},

[David Tseng, 2016-10-21 06:11:53]

Description was changed from

==========
Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of
https://codereview.chromium.org/2387533003/ )

Reason for revert:
crbug.com/658045

Original issue's description:
> Accessibility: Ignore all anonymous blocks
> 
> Anonymous blocks are an implementation detail of the
> Blink layout tree. They're surprising and not useful in
> the accessibility tree. Get rid of them by marking them
> all as ignored.
> 
> While it may seem counterintuitive, this is actually
> part of a longer-term plan to get rid of the idea of
> ignoring nodes for accessibility, this will bring us
> closer to just exposing the DOM tree plus generated
> content, like FIrefox and IE do.
> 
> The code change here is tiny, most of the change is
> rebasing or updating dozens and dozens of affected
> tests. I deleted a couple of tests that specifically
> tested corner cases involving anonymous blocks;
> the whole point of this change is to not make this a
> special case anymore.
> 
> Also updates this script, designed to automatically
> pull test output from try servers to a local change:
> 
> tools/accessibility/rebase_dump_accessibility_tree_test.py
> 
> BUG=651614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of
https://codereview.chromium.org/2387533003/ )

Reason for revert:
crbug.com/658045

Original issue's description:
> Accessibility: Ignore all anonymous blocks
> 
> Anonymous blocks are an implementation detail of the
> Blink layout tree. They're surprising and not useful in
> the accessibility tree. Get rid of them by marking them
> all as ignored.
> 
> While it may seem counterintuitive, this is actually
> part of a longer-term plan to get rid of the idea of
> ignoring nodes for accessibility, this will bring us
> closer to just exposing the DOM tree plus generated
> content, like FIrefox and IE do.
> 
> The code change here is tiny, most of the change is
> rebasing or updating dozens and dozens of affected
> tests. I deleted a couple of tests that specifically
> tested corner cases involving anonymous blocks;
> the whole point of this change is to not make this a
> special case anymore.
> 
> Also updates this script, designed to automatically
> pull test output from try servers to a local change:
> 
> tools/accessibility/rebase_dump_accessibility_tree_test.py
> 
> BUG=651614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed:
https://chromium.googlesource.com/chromium/src/+/e4db7ae216888672805a38d8f8fe...
==========

[David Tseng, 2016-10-21 06:11:54]

Committed patchset #5 (id:360001) manually as
e4db7ae216888672805a38d8f8fee54c836357c9 (presubmit successful).

[commit-bot: I haz the power, 2016-10-21 13:27:43]

Description was changed from

==========
Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of
https://codereview.chromium.org/2387533003/ )

Reason for revert:
crbug.com/658045

Original issue's description:
> Accessibility: Ignore all anonymous blocks
> 
> Anonymous blocks are an implementation detail of the
> Blink layout tree. They're surprising and not useful in
> the accessibility tree. Get rid of them by marking them
> all as ignored.
> 
> While it may seem counterintuitive, this is actually
> part of a longer-term plan to get rid of the idea of
> ignoring nodes for accessibility, this will bring us
> closer to just exposing the DOM tree plus generated
> content, like FIrefox and IE do.
> 
> The code change here is tiny, most of the change is
> rebasing or updating dozens and dozens of affected
> tests. I deleted a couple of tests that specifically
> tested corner cases involving anonymous blocks;
> the whole point of this change is to not make this a
> special case anymore.
> 
> Also updates this script, designed to automatically
> pull test output from try servers to a local change:
> 
> tools/accessibility/rebase_dump_accessibility_tree_test.py
> 
> BUG=651614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed:
https://chromium.googlesource.com/chromium/src/+/e4db7ae216888672805a38d8f8fe...
==========

to

==========
Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of
https://codereview.chromium.org/2387533003/ )

Reason for revert:
crbug.com/658045

Original issue's description:
> Accessibility: Ignore all anonymous blocks
>
> Anonymous blocks are an implementation detail of the
> Blink layout tree. They're surprising and not useful in
> the accessibility tree. Get rid of them by marking them
> all as ignored.
>
> While it may seem counterintuitive, this is actually
> part of a longer-term plan to get rid of the idea of
> ignoring nodes for accessibility, this will bring us
> closer to just exposing the DOM tree plus generated
> content, like FIrefox and IE do.
>
> The code change here is tiny, most of the change is
> rebasing or updating dozens and dozens of affected
> tests. I deleted a couple of tests that specifically
> tested corner cases involving anonymous blocks;
> the whole point of this change is to not make this a
> special case anymore.
>
> Also updates this script, designed to automatically
> pull test output from try servers to a local change:
>
> tools/accessibility/rebase_dump_accessibility_tree_test.py
>
> BUG=651614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e4db7ae216888672805a38d8f8fee54c836357c9
Cr-Commit-Position: refs/heads/master@{#426736}
==========

[David Tseng, 2016-10-21 20:56:27]

A revert of this CL (patchset #5 id:360001) has been created in
https://codereview.chromium.org/2439203003/ by dtseng@chromium.org.

The reason for reverting is: Turns out this wasn't the root cause of the bug;
even though it was the result of a bisect; sorry for the noise.