Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2265)

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/queryselector.js

Issue 2440833002: Revert of Accessibility: Ignore all anonymous blocks (Closed)
Patch Set: Rebase after revert of another change touching cursors_test.js Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/automation/tests/tabs/queryselector.js
diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/queryselector.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/queryselector.js
index 2794068bd4b10c7a6cf2817e3531423917cfaf72..65489e390f1624d5f8327c1d1c4f54faa28a182d 100644
--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/queryselector.js
+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/queryselector.js
@@ -5,7 +5,7 @@
var allTests = [
// Basic query from root node.
function testQuerySelector() {
- var cancelButton = rootNode.children[3];
+ var cancelButton = rootNode.lastChild.lastChild;
function assertCorrectResult(queryResult) {
assertEq(queryResult, cancelButton);
chrome.test.succeed();
@@ -39,7 +39,7 @@ var allTests = [
// Demonstrates that a query for an element which is ignored for accessibility
// returns its nearest ancestor.
function testQuerySelectorForSpanInsideButtonReturnsButton() {
- var okButton = rootNode.children[2];
+ var okButton = rootNode.lastChild.firstChild;
function assertCorrectResult(queryResult) {
assertEq(queryResult, okButton);
chrome.test.succeed();
@@ -47,6 +47,18 @@ var allTests = [
rootNode.domQuerySelector('#span-in-button', assertCorrectResult);
},
+ // Demonstrates that querying from an anonymous node may have unexpected
+ // results.
+ function testQuerySelectorFromAnonymousGroup() {
+ var h1 = rootNode.firstChild.firstChild;
+ var group = rootNode.lastChild;
+ function assertCorrectResult(queryResult) {
+ assertEq(h1, queryResult);
+ chrome.test.succeed();
+ }
+ group.domQuerySelector('h1', assertCorrectResult);
+ },
+
function testQuerySelectorFromRemovedNode() {
var group = rootNode.firstChild;
function assertCorrectResult(queryResult) {

Powered by Google App Engine
This is Rietveld 408576698