Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: ui/views/controls/button/toggle_button.h

Issue 2440723003: Tweaks to ToggleButton details. (Closed)
Patch Set: colors Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/button/toggle_button.cc » ('j') | ui/views/controls/button/toggle_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/toggle_button.h
diff --git a/ui/views/controls/button/toggle_button.h b/ui/views/controls/button/toggle_button.h
index 2780b9f8af6da59ac7023249d3d99caffd4d574f..017f8793186b68bfebafd7daad438bb8795a53cc 100644
--- a/ui/views/controls/button/toggle_button.h
+++ b/ui/views/controls/button/toggle_button.h
@@ -49,9 +49,11 @@ class VIEWS_EXPORT ToggleButton : public CustomButton {
// gfx::AnimationDelegate:
void AnimationProgressed(const gfx::Animation* animation) override;
+ SkColor GetTrackColor(bool is_on) const;
varkha 2016/10/21 00:35:18 nit: I think the style guide asked for the overrid
Evan Stade 2016/10/21 17:19:15 I don't think it specifies[1] and I believe (witho
varkha 2016/10/21 17:55:36 No strong opinion here. Just needs to be consisten
sadrul 2016/10/24 14:46:12 In ui code, I think we fairly consistently put non
+
bool is_on_;
gfx::SlideAnimation slide_animation_;
- std::unique_ptr<ThumbView> thumb_view_;
+ ThumbView* thumb_view_;
DISALLOW_COPY_AND_ASSIGN(ToggleButton);
};
« no previous file with comments | « no previous file | ui/views/controls/button/toggle_button.cc » ('j') | ui/views/controls/button/toggle_button.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698