Tweaks to ToggleButton details.

ui/views/controls/button/toggle_button.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_BUTTON_TOGGLE_BUTTON_H_
 #define UI_VIEWS_CONTROLS_BUTTON_TOGGLE_BUTTON_H_
 
 #include "ui/gfx/animation/slide_animation.h"
 #include "ui/views/controls/button/custom_button.h"
 
@@ skipping 31 matching lines @@
   void OnNativeThemeChanged(const ui::NativeTheme* theme) override;
   void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
   void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;
   std::unique_ptr<InkDropRipple> CreateInkDropRipple() const override;
   SkColor GetInkDropBaseColor() const override;
   bool ShouldShowInkDropHighlight() const override;
 
   // gfx::AnimationDelegate:
   void AnimationProgressed(const gfx::Animation* animation) override;
 
+  SkColor GetTrackColor(bool is_on) const;

[varkha, 2016/10/21 00:35:18]

nit: I think the style guide asked for the overrides to be after local methods.

[Evan Stade, 2016/10/21 17:19:15]

I don't think it specifies[1] and I believe (without substantiation) it's more
common in Chrome to put overrides first.

[1] https://google.github.io/styleguide/cppguide.html#Declaration_Order

[varkha, 2016/10/21 17:55:36]

No strong opinion here. Just needs to be consistent with the rest of order
(which I have changed because I had this suggested in my CL -
https://codereview.chromium.org/2396133005/diff/80001/ui/views/controls/butto...).

[sadrul, 2016/10/24 14:46:12]

In ui code, I think we fairly consistently put non-overrides before overrides.

+
   bool is_on_;
   gfx::SlideAnimation slide_animation_;
-  std::unique_ptr<ThumbView> thumb_view_;
+  ThumbView* thumb_view_;
 
   DISALLOW_COPY_AND_ASSIGN(ToggleButton);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_BUTTON_TOGGLE_BUTTON_H_