Use AudioUtilities::kRenderQuantumFrames everywhere

Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG=657620
TESTS=none; an internal change not visible.

Committed: https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410
Cr-Commit-Position: refs/heads/master@{#428875}

[Raymond Toy, 2016-10-19 21:06:22]

Description was changed from

==========
Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

BUG=
TESTS=none; an internal change not visible.
==========

to

==========
Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said 
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG=
TESTS=none; an internal change not visible.
==========

[Raymond Toy, 2016-10-19 22:34:23]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-10-19 22:34:24]

PTAL.

[Raymond Toy, 2016-10-19 22:35:10]

Description was changed from

==========
Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said 
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG=
TESTS=none; an internal change not visible.
==========

to

==========
Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said 
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG=657620
TESTS=none; an internal change not visible.
==========

[hongchan, 2016-10-24 16:23:24]

I am still not sure which is the right design:

1. Make all the parts render-quantum-size-agnostic. (by passing the RQ size as
an argument.)
2. Have a singleton static value in Context, and use it implicitly everywhere.
Remove the RQ size from the all arguments.

However, I do not want the mixture of both. I think we should pick one.

https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParam.cpp (right):

https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.cpp:277: // equal to
AudioHandler::AudioUtilities::kRenderQuantumFrames (the render
Remove 'AudioHandler::'

[Raymond Toy, 2016-10-26 17:09:08]

On 2016/10/24 16:23:24, hongchan wrote:
> I am still not sure which is the right design:
> 
> 1. Make all the parts render-quantum-size-agnostic. (by passing the RQ size as
> an argument.)

I think they already do.  The issue is that some methods allocate fixed-size
arrays
to be used.  We certainly could change the code to allocate space dynamically
but
that slows things down (very slightly?)

> 2. Have a singleton static value in Context, and use it implicitly everywhere.
> Remove the RQ size from the all arguments.

Not sure that would work.  Not all methods have access to that, I think.
> 
> However, I do not want the mixture of both. I think we should pick one.
> 
>
https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/webaudio/AudioParam.cpp (right):
> 
>
https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/webaudio/AudioParam.cpp:277: // equal to
> AudioHandler::AudioUtilities::kRenderQuantumFrames (the render
> Remove 'AudioHandler::'

[hongchan, 2016-10-31 21:39:14]

On 2016/10/26 17:09:08, Raymond Toy wrote:
> On 2016/10/24 16:23:24, hongchan wrote:
> > I am still not sure which is the right design:
> > 
> > 1. Make all the parts render-quantum-size-agnostic. (by passing the RQ size
as
> > an argument.)
> 
> I think they already do.  The issue is that some methods allocate fixed-size
> arrays
> to be used.  We certainly could change the code to allocate space dynamically
> but
> that slows things down (very slightly?)
> 
> > 2. Have a singleton static value in Context, and use it implicitly
everywhere.
> > Remove the RQ size from the all arguments.
> 
> Not sure that would work.  Not all methods have access to that, I think.
> > 
> > However, I do not want the mixture of both. I think we should pick one.
> > 
> >
>
https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/modules/webaudio/AudioParam.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/modules/webaudio/AudioParam.cpp:277: // equal to
> > AudioHandler::AudioUtilities::kRenderQuantumFrames (the render
> > Remove 'AudioHandler::'

If you're not feeling strong about this change, I think we should re-think about
the refactoring approach.

[Raymond Toy, 2016-10-31 22:30:06]

https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParam.cpp (right):

https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParam.cpp:277: // equal to
AudioHandler::AudioUtilities::kRenderQuantumFrames (the render
On 2016/10/24 at 16:23:24, hongchan wrote:
> Remove 'AudioHandler::'

Done (with a few other cosmetic changes like |numberOfValues| and reindenting.

[Raymond Toy, 2016-10-31 22:38:43]

On 2016/10/31 at 21:39:14, hongchan wrote:
> On 2016/10/26 17:09:08, Raymond Toy wrote:
> > On 2016/10/24 16:23:24, hongchan wrote:
> > > I am still not sure which is the right design:
> > > 
> > > 1. Make all the parts render-quantum-size-agnostic. (by passing the RQ
size as
> > > an argument.)
> > 
> > I think they already do.  The issue is that some methods allocate fixed-size
> > arrays
> > to be used.  We certainly could change the code to allocate space
dynamically
> > but
> > that slows things down (very slightly?)
> > 
> > > 2. Have a singleton static value in Context, and use it implicitly
everywhere.
> > > Remove the RQ size from the all arguments.
> > 
> > Not sure that would work.  Not all methods have access to that, I think.
> > > 
> > > However, I do not want the mixture of both. I think we should pick one.
> > > 
> > >
> >
https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
> > > File third_party/WebKit/Source/modules/webaudio/AudioParam.cpp (right):
> > > 
> > >
> >
https://codereview.chromium.org/2440583002/diff/20001/third_party/WebKit/Sour...
> > > third_party/WebKit/Source/modules/webaudio/AudioParam.cpp:277: // equal to
> > > AudioHandler::AudioUtilities::kRenderQuantumFrames (the render
> > > Remove 'AudioHandler::'
> 
> If you're not feeling strong about this change, I think we should re-think
about the refactoring approach.

After an offline discussion, we've decided to go ahead with this change.  It's
not the best, but at least
all uses will have the same name so that when we do refactor the code, it's easy
to find all the uses.

[hongchan, 2016-10-31 22:43:04]

lgtm

[Raymond Toy, 2016-10-31 22:47:29]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:48:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 00:10:27]

Description was changed from

==========
Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said 
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG=657620
TESTS=none; an internal change not visible.
==========

to

==========
Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said 
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG=657620
TESTS=none; an internal change not visible.
==========

[commit-bot: I haz the power, 2016-11-01 00:10:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-01 00:15:02]

Description was changed from

==========
Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said 
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG=657620
TESTS=none; an internal change not visible.
==========

to

==========
Use AudioUtilities::kRenderQuantumFrames everywhere

Use this instead of AudioHandler::ProcessingSizeInFrames so that
there's only one definition of the rendering size.

Basically ran

sed -i 's;ProcessingSizeInFrames;AudioUtilities::kRenderQuantumFrames;g'

for all files and then manually fixing up a few places that said
AudioHandler::AudioUtilities::kRenderQuantumFrames

BUG=657620
TESTS=none; an internal change not visible.

Committed: https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410
Cr-Commit-Position: refs/heads/master@{#428875}
==========

[commit-bot: I haz the power, 2016-11-01 00:15:03]

Patchset 3 (id:??) landed as
https://crrev.com/b7198aeec6e82994ef5060872852997fccd74410
Cr-Commit-Position: refs/heads/master@{#428875}