Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParam.cpp

Issue 2440583002: Use AudioUtilities::kRenderQuantumFrames everywhere (Closed)
Patch Set: Address review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp b/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
index 32bcebef90579bf1ebf8dd350d8b55fbc724ff33..ab72ab86e37398e07be107b0bf709446fd07a3d9 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
@@ -264,7 +264,7 @@ void AudioParamHandler::calculateFinalValues(float* values,
// Render audio from this output.
AudioBus* connectionBus =
- output->pull(0, AudioHandler::ProcessingSizeInFrames);
+ output->pull(0, AudioUtilities::kRenderQuantumFrames);
// Sum, with unity-gain.
summingBus->sumFrom(*connectionBus);
@@ -273,8 +273,9 @@ void AudioParamHandler::calculateFinalValues(float* values,
void AudioParamHandler::calculateTimelineValues(float* values,
unsigned numberOfValues) {
- // Calculate values for this render quantum. Normally numberOfValues will
- // equal to AudioHandler::ProcessingSizeInFrames (the render quantum size).
+ // Calculate values for this render quantum. Normally
+ // |numberOfValues| will equal to
+ // AudioUtilities::kRenderQuantumFrames (the render quantum size).
double sampleRate = destinationHandler().sampleRate();
size_t startFrame = destinationHandler().currentSampleFrame();
size_t endFrame = startFrame + numberOfValues;

Powered by Google App Engine
This is Rietveld 408576698