SUCCEEDED macro is misused

webrtc/modules/desktop_capture/screen_drawer_win.cc

Index: webrtc/modules/desktop_capture/screen_drawer_win.cc
diff --git a/webrtc/modules/desktop_capture/screen_drawer_win.cc b/webrtc/modules/desktop_capture/screen_drawer_win.cc
index 0b669916479c876366ac0237557745e693f37a3a..d02f7c07a84e8f7ff070b762adc2a57b561c4f97 100644
--- a/webrtc/modules/desktop_capture/screen_drawer_win.cc
+++ b/webrtc/modules/desktop_capture/screen_drawer_win.cc
@@ -174,8 +174,8 @@ void ScreenDrawerWin::DrawDot(DesktopVector vect, RgbaColor color) {
 }
 
 void ScreenDrawerWin::BringToFront() {
-  if (SUCCEEDED(SetWindowPos(
-      window_, HWND_TOPMOST, 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE))) {
+  if (SetWindowPos(window_, HWND_TOPMOST, 0, 0, 0, 0,
+                   SWP_NOMOVE | SWP_NOSIZE) == TRUE) {
     return;

[tommi (sloooow) - chröme, 2016/10/20 19:51:20]

Nit: Just check for non 0. False has one value, true is all the other ones. See
e.g a couple of lines below. 

[Hzj_jie, 2016/10/20 21:13:39]

Will value != FALSE better?

   }