SUCCEEDED macro is misused

webrtc/modules/desktop_capture/screen_drawer_win.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 156 matching lines @@
   points[1].y = end.y();
   SetDCPenColor(hdc_, ColorToRef(color));
   Polyline(hdc_, points, 2);
 }
 
 void ScreenDrawerWin::DrawDot(DesktopVector vect, RgbaColor color) {
   SetPixel(hdc_, vect.x(), vect.y(), ColorToRef(color));
 }
 
 void ScreenDrawerWin::BringToFront() {
-  if (SUCCEEDED(SetWindowPos(
-      window_, HWND_TOPMOST, 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE))) {
+  if (SetWindowPos(window_, HWND_TOPMOST, 0, 0, 0, 0,
+                   SWP_NOMOVE | SWP_NOSIZE) == TRUE) {
     return;

[tommi (sloooow) - chröme, 2016/10/20 19:51:20]

Nit: Just check for non 0. False has one value, true is all the other ones. See
e.g a couple of lines below. 

[Hzj_jie, 2016/10/20 21:13:39]

Will value != FALSE better?

   }
 
   long ex_style = GetWindowLong(window_, GWL_EXSTYLE);
   ex_style |= WS_EX_TOPMOST;
   if (SetWindowLong(window_, GWL_EXSTYLE, ex_style) != 0) {
     return;
   }
 
   BringWindowToTop(window_);
 }
 
 }  // namespace
 
 // static
 std::unique_ptr<ScreenDrawerLock> ScreenDrawerLock::Create() {
   return std::unique_ptr<ScreenDrawerLock>(new ScreenDrawerLockWin());
 }
 
 // static
 std::unique_ptr<ScreenDrawer> ScreenDrawer::Create() {
   return std::unique_ptr<ScreenDrawer>(new ScreenDrawerWin());
 }
 
 }  // namespace webrtc