Make GroupedPermissionInfoBarDelegate's methods call through PermissionPromptAndroid

chrome/browser/permissions/grouped_permission_infobar_delegate_android.h

Index: chrome/browser/permissions/grouped_permission_infobar_delegate_android.h
diff --git a/chrome/browser/permissions/grouped_permission_infobar_delegate_android.h b/chrome/browser/permissions/grouped_permission_infobar_delegate_android.h
index 7971869757fd362371073c7d363027e8ca91e438..cc427208d8a16f219fb1712d4fb26e4c9d692c62 100644
--- a/chrome/browser/permissions/grouped_permission_infobar_delegate_android.h
+++ b/chrome/browser/permissions/grouped_permission_infobar_delegate_android.h
@@ -13,6 +13,7 @@
 
 class GURL;
 class InfoBarService;
+class PermissionPromptAndroid;
 class PermissionRequest;
 
 // An InfoBar that displays a group of permission requests, each of which can be
@@ -24,6 +25,7 @@ class GroupedPermissionInfoBarDelegate : public ConfirmInfoBarDelegate {
   ~GroupedPermissionInfoBarDelegate() override;
 
   static infobars::InfoBar* Create(
+      PermissionPromptAndroid* permission_prompt,
       InfoBarService* infobar_service,
       const GURL& requesting_origin,
       const std::vector<PermissionRequest*>& requests);
@@ -47,6 +49,8 @@ class GroupedPermissionInfoBarDelegate : public ConfirmInfoBarDelegate {
 
   // ConfirmInfoBarDelegate:
   base::string16 GetMessageText() const override;
+  bool Accept() override;
+  bool Cancel() override;
 
  protected:
   bool GetAcceptState(size_t position);
@@ -54,7 +58,8 @@ class GroupedPermissionInfoBarDelegate : public ConfirmInfoBarDelegate {
  private:
   GroupedPermissionInfoBarDelegate(
       const GURL& requesting_origin,
-      const std::vector<PermissionRequest*>& requests);
+      const std::vector<PermissionRequest*>& requests,
+      PermissionPromptAndroid* permission_prompt);
 
   // ConfirmInfoBarDelegate:
   InfoBarIdentifier GetIdentifier() const override;
@@ -67,6 +72,9 @@ class GroupedPermissionInfoBarDelegate : public ConfirmInfoBarDelegate {
   std::vector<bool> accept_states_;
   // Whether the accept/deny decision is persisted.
   bool persist_;
+  // PermissionPromptAndroid's lifetime matches that of this object as it
+  // controls the lifetime of the infobar which we are a delegate to.

[raymes, 2016/10/27 01:32:33]

Hmm - it's not immediately clear to me that the PermissionPromptAndroid's
lifetime will outlast the InfoBar's lifetime, since the InfoBar is actually
managed by the InfoBarService. For example, even calling RemoveInfobar won't
necessarily cause the Infobar to be deleted synchronously. I wonder if we need
to hold a WeakPtr here? I'm not certain though - it's not simple to reason about
at least. Do you or Dom have any insights?

[lshang, 2016/10/28 03:18:48]

I think your point makes sense, that's a tricky one. PermissionRequestManager
will delete PermissionPrompt after calls to hide bubble, but I'm not sure if
user could still interact with bubble's buttons during this time, or the bubble
close animation got delayed for some reason. 

Use WeakPtr should be safer. Or we could also dynamically get PermissionPrompt
from PermissionRequestManager to see if it has been destroyed or not.

+  PermissionPromptAndroid* permission_prompt_;
 
   DISALLOW_COPY_AND_ASSIGN(GroupedPermissionInfoBarDelegate);
 };